Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically comment prettier diff #36

Closed
wants to merge 3 commits into from
Closed

Conversation

aaronmgdr
Copy link
Member

When prettier runs and has a diff that will cause the pr to not be mergable.

Since we cant make commits on a fork from a gh action and commits made on gh ui dont run precommit hooks this action will leave a commit on the pr with the changes to be made. saving both maintainers and contributors from needing to pull and run prettier locally,

@aaronmgdr aaronmgdr requested review from jmrossy and a team as code owners August 22, 2024 13:17
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celo-mondo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 1:27pm

@aaronmgdr
Copy link
Member Author

oh no this doesnt support forks either! parkerbxyz/suggest-changes#33

i dont get why

@aaronmgdr aaronmgdr closed this Aug 23, 2024
@parkerbxyz
Copy link

Looks like the workflow job is missing the required permissions: parkerbxyz/suggest-changes#33 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants