Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegatee registration form #51

Merged
merged 24 commits into from
Oct 3, 2024
Merged

Delegatee registration form #51

merged 24 commits into from
Oct 3, 2024

Conversation

shazarre
Copy link
Contributor

@shazarre shazarre commented Sep 19, 2024 •
edited
Loading

  • introduce better types for responses/requests
  • move validation code to a separate file/function
  • backend validation
  • rephrase message shown to the user upon successful form submission
  • send signature from the client and verify on the backend
  • create github bot + configure the env
  • error handling (ie when creating a PR fails)
  • "website": null, shouldn't be there in the JSON
  • Change CTA text to match the new way of registering, in case someone doesn't want to use their connected wallet address provide instructions for raising a PR (like in original CTA)
  • add a build step to combine separate JSON files with current JSON file (so it can be accessed from the client)
  • add basic test coverage

@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celo-mondo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 3:14pm

@shazarre shazarre changed the title WIP Delegatee registration form Sep 19, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Oct 2, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@octokit/[email protected] None 0 96.5 kB octokitbot
npm/@octokit/[email protected] None 0 97.2 kB gr2m, kfcampbell, nickfloyd, ...1 more
npm/@octokit/[email protected] None 0 47.4 kB octokitbot
npm/@octokit/[email protected] None 0 38.8 kB octokitbot
npm/@octokit/[email protected] None 0 61.2 kB octokitbot
npm/@octokit/[email protected] None 0 19 kB octokitbot
npm/@octokit/[email protected] None 0 23.4 kB octokitbot
npm/@octokit/[email protected] None 0 23 kB octokitbot
npm/@octokit/[email protected] None 0 59.4 kB octokitbot
npm/@octokit/[email protected] None 0 28.9 kB octokitbot
npm/@octokit/[email protected] None 0 146 kB octokitbot
npm/@octokit/[email protected] None 0 12.8 kB octokitbot
npm/@octokit/[email protected] None 0 96.5 kB octokitbot
npm/@octokit/[email protected] None 0 4.26 MB octokitbot
npm/@octokit/[email protected] None 0 2.59 MB octokitbot
npm/@octokit/[email protected] None 0 35.5 kB octokitbot
npm/@octokit/[email protected] None 0 167 kB octokitbot
npm/@octokit/[email protected] None 0 1.25 MB octokitbot
npm/@octokit/[email protected] None 0 15.9 kB octokitbot
npm/@octokit/[email protected] None 0 38.7 kB octokitbot
npm/@octokit/[email protected] None 0 6.37 kB octokitbot
npm/@octokit/[email protected] None 0 43.8 kB octokitbot
npm/@octokit/[email protected] None 0 239 kB octokitbot
npm/@octokit/[email protected] None 0 22.9 kB octokitbot
npm/@octokit/[email protected] None 0 157 kB octokitbot
npm/@rollup/[email protected] None 0 1.46 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.06 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.18 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.33 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.22 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.22 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.2 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.12 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.76 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.25 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 3.84 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.46 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.46 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.76 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 2.53 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] None 0 3.28 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@types/[email protected] None 0 166 kB types
npm/@types/[email protected] None 0 25.8 kB types
npm/@vitest/[email protected] None 0 149 kB vitestbot
npm/@vitest/[email protected] None 0 121 kB vitestbot
npm/@vitest/[email protected] environment 0 45.3 kB vitestbot
npm/@vitest/[email protected] None 0 87.9 kB vitestbot
npm/@vitest/[email protected] None 0 0 B
npm/@vitest/[email protected] None 0 19.1 kB vitestbot
npm/@vitest/[email protected] None 0 153 kB antfu, oreanno, patak, ...1 more
npm/[email protected] environment 0 17.3 kB sindresorhus
npm/[email protected] None 0 5.83 kB chaijs
npm/[email protected] None 0 35.5 kB gr2m
npm/[email protected] eval 0 629 kB sgrondin
npm/[email protected] None 0 81.8 kB egoist
npm/[email protected] None 0 506 kB chaijs
npm/[email protected] None 0 11.4 kB chaijs
npm/[email protected] None 0 23.9 kB chaijs
npm/[email protected] None 0 17.6 kB rich_harris
npm/[email protected] None 0 8.68 kB keithamus
npm/[email protected] None 0 60.5 kB chaijs
npm/[email protected] None 0 464 kB antfu
npm/[email protected] None 0 51.2 kB octokitbot
npm/[email protected] None 0 15 kB chaijs
npm/[email protected] None 0 2.59 MB eventualbuddha, lukastaegert, rich_harris, ...2 more
npm/[email protected] None 0 4.79 kB emilbayes
npm/[email protected] None 0 6.88 kB shtylman
npm/[email protected] None 0 62.9 kB aslemammad
npm/[email protected] environment, shell 0 45.4 kB 43081j
npm/[email protected] filesystem, shell, unsafe 0 49.9 kB ariperkkio
npm/[email protected] None 0 7.91 kB oreanno
npm/[email protected] None 0 17.6 kB antfu, aslemammad, oreanno
npm/[email protected] None 0 31.4 kB gr2m
npm/[email protected] None 0 8.14 kB gr2m
npm/[email protected] None 0 202 kB antfu, oreanno, patak, ...1 more
npm/[email protected] None 0 3.26 MB antfu, patak, soda, ...2 more
npm/[email protected] None 0 1.62 MB antfu, oreanno, patak, ...1 more
npm/[email protected] filesystem, unsafe 0 7.3 kB mafintosh

🚮 Removed packages: npm/@ampproject/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@bcoe/[email protected], npm/@istanbuljs/[email protected], npm/@istanbuljs/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@sinonjs/[email protected], npm/@sinonjs/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@shazarre shazarre marked this pull request as ready for review October 3, 2024 11:52
@shazarre shazarre requested review from jmrossy and a team as code owners October 3, 2024 11:52
aaronmgdr
aaronmgdr approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beaut

@shazarre shazarre merged commit 042f8f8 into main Oct 3, 2024
10 checks passed
@shazarre shazarre deleted the shazarre/delegatee_registration_form branch October 3, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasbrugneaux nicolasbrugneaux nicolasbrugneaux left review comments

@aaronmgdr aaronmgdr aaronmgdr approved these changes

@jmrossy jmrossy Awaiting requested review from jmrossy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shazarre @nicolasbrugneaux @aaronmgdr