Update retry.go to handle hung operations #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update retry.go to launch the operation in an asynchronous manner and deal with an operation that hangs
|
The failing test cases are cases that return both a value and an error. From a limited search, it seems that go conventions are to ignore result value when an error returned in non-nil. The code change I made, made it so it if the operation returns an error, then only the error is returned. I suppose this would be a breaking change, I can re-work the code to return both error and result, if operation returns both, if that would be desired. |
Adding test with simulated hang
Return Res + Error to avoid making a breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update retry.go to launch the operation in an asynchronous manner and deal with an operation that hangs