feat: allow to use a non-root S3 bucket location #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this project! While evaluating it, came across a few things that would make life easier for me, so here is the first one :) |
satlank
commented
Sep 23, 2024
| * `REGISTRY_S3_ACCESS_KEY`: The access key to use | ||
| * `REGISTRY_S3_SECRET_KEY`: The secret key to use | ||
| * `REGISTRY_S3_ACCESS_KEY`: The access key to use, set to empty string to search for existing credentials. | ||
| * `REGISTRY_S3_SECRET_KEY`: The secret key to use, set to empty string to search for existing credentials. |
There was a problem hiding this comment.
Not entirely related, but took a while to figure it out (I want to let OpenDAL deal with sorting out the credentials instead).
| @@ -110,6 +110,7 @@ impl StorageConfig { | |||
| region: get_var("REGISTRY_S3_REGION")?, | |||
| access_key: get_var("REGISTRY_S3_ACCESS_KEY")?, | |||
| secret_key: get_var("REGISTRY_S3_SECRET_KEY")?, | |||
| root: get_var("REGISTRY_S3_ROOT").unwrap_or_default(), | |||
There was a problem hiding this comment.
The unwrap_or_default is here to make setting this env variable optional, but could also require it and as for the keys an empty string would be 'do the default thing of going to the top-level'.
woutersl
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to direct cratery to use a 'subdirectory' to store its data on S3. This is useful to not have to dedicate a bucket to cratery (which may or may not be appropriate). E.g. instead of using
my-cratery-bucket/we can now usemy-multipurpose-bucket/cratery/.