fix(process): Deadlocks removed in process/process_manager (#67)

    * enh(cmake): new possibility to compile with clang and with libc++
    * fix(process): With clang, this file did not compile
    * enh(process): new tests
    * fix(process): wait on condition variable protected now.
    * fix(process_manager): attempt to join add() and update_list()
    * fix(process_manager): mutexes management modified.
    * cleanup(process_manager): Dead code removed and comments added.
    * fix(test): unit tests re enabled for some of them.
    * fix(process): wait() could badly wait.
    * fix(process): warnings removed.
    * fix(process_manager): orphans management was broken
    * cleanup(gitignore): new files to ignore
    * doc(process_manager): Improvement of the doc
    * cleanup(various): coding style
    * fix(process_manager): a process can be stopped very early, before being stored in the manager

    REFS: MON-11027

.gitignore

@@ -1,2 +1,8 @@
+.*.swp
+.vscode
+CMakeLists.txt.user
 build/*
+deps.png
 inc/com/centreon/clib/version.hh
+script/centreon-clib.pc
+tags

CHANGELOG.md

@@ -14,6 +14,13 @@ informations.
 This one is in the process class. When the process is stopping and we write to
 its stdin, we could arrive to a deadlock.
 
+Another one in the process\_manager class is also fixed.
+
+*Fast processes*
+
+If process fastly writes to stdout and then exits, process\_manager could miss
+the output.
+
 ## 20.10.3
 
 ### Bug fixes

CMakeLists.txt

@@ -20,6 +20,8 @@
 cmake_minimum_required(VERSION 2.8)
 project("Centreon Clib" C CXX)
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14")
+#set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14 -stdlib=libc++")
+#set(CMAKE_CXX_COMPILER "clang++")
 add_definitions("-D_GLIBCXX_USE_CXX11_ABI=1")
 
 # Set directories.

inc/com/centreon/exceptions/basic.hh

@@ -50,7 +50,7 @@ class basic : public std::exception {
 
   misc::stringifier _buffer;
 };
-}
+}  // namespace exceptions
 
 CC_END()
 

inc/com/centreon/exceptions/interruption.hh

@@ -47,7 +47,7 @@ class interruption : public basic {
     return (*this);
   }
 };
-}
+}  // namespace exceptions
 
 CC_END()
 

inc/com/centreon/io/directory_entry.hh

@@ -21,8 +21,8 @@
 
 #include <list>
 #include <string>
-#include "com/centreon/io/file_entry.hh"
 #include "com/centreon/handle.hh"
+#include "com/centreon/io/file_entry.hh"
 #include "com/centreon/namespace.hh"
 
 CC_BEGIN()
@@ -55,7 +55,7 @@ class directory_entry {
   file_entry _entry;
   std::list<file_entry> _entry_lst;
 };
-}
+}  // namespace io
 
 CC_END()
 

inc/com/centreon/io/file_entry.hh

@@ -19,9 +19,9 @@
 #ifndef CC_IO_FILE_ENTRY_HH
 #define CC_IO_FILE_ENTRY_HH
 
-#include <string>
-#include <sys/types.h>
 #include <sys/stat.h>
+#include <sys/types.h>
+#include <string>
 #include "com/centreon/handle.hh"
 #include "com/centreon/namespace.hh"
 
@@ -65,7 +65,7 @@ class file_entry {
   std::string _path;
   struct stat _sbuf;
 };
-}
+}  // namespace io
 
 CC_END()
 

inc/com/centreon/io/file_stream.hh

@@ -63,7 +63,7 @@ class file_stream : public handle {
   bool _auto_close;
   FILE* _stream;
 };
-}
+}  // namespace io
 
 CC_END()
 

inc/com/centreon/logging/backend.hh

@@ -29,12 +29,7 @@ class stringifier;
 }
 
 namespace logging {
-enum time_precision {
-  none = 0,
-  microsecond = 1,
-  millisecond = 2,
-  second = 3
-};
+enum time_precision { none = 0, microsecond = 1, millisecond = 2, second = 3 };
 
 /**
  *  @class backend backend.hh "com/centreon/logging/backend.hh"
@@ -81,7 +76,7 @@ class backend {
  protected:
   void _internal_copy(backend const& right);
 };
-}
+}  // namespace logging
 
 CC_END()
 

inc/com/centreon/logging/engine.hh

@@ -89,7 +89,7 @@ class engine {
   unsigned long long _list_types[sizeof(unsigned int) * CHAR_BIT];
   mutable std::mutex _mtx;
 };
-}
+}  // namespace logging
 
 CC_END()
 

inc/com/centreon/logging/file.hh

@@ -68,7 +68,7 @@ class file : public backend {
   FILE* _out;
   uint64_t _size;
 };
-}
+}  // namespace logging
 
 CC_END()
 

inc/com/centreon/logging/logger.hh

@@ -30,20 +30,16 @@ enum type_value {
   type_error = (1ull << 63)
 };
 
-enum verbosity_level {
-  low = 0,
-  medium = 1,
-  high = 2
-};
-}
+enum verbosity_level { low = 0, medium = 1, high = 2 };
+}  // namespace logging
 
 CC_END()
 
 #define log_info(verbose)                                                \
   for (unsigned int __com_centreon_logging_define_ui(0);                 \
        !__com_centreon_logging_define_ui &&                              \
-           com::centreon::logging::engine::instance().is_log(            \
-               com::centreon::logging::type_info, verbose);              \
+       com::centreon::logging::engine::instance().is_log(                \
+           com::centreon::logging::type_info, verbose);                  \
        ++__com_centreon_logging_define_ui)                               \
   com::centreon::logging::temp_logger(com::centreon::logging::type_info, \
                                       verbose)                           \
@@ -52,8 +48,8 @@ CC_END()
 #define log_debug(verbose)                                                \
   for (unsigned int __com_centreon_logging_define_ui(0);                  \
        !__com_centreon_logging_define_ui &&                               \
-           com::centreon::logging::engine::instance().is_log(             \
-               com::centreon::logging::type_debug, verbose);              \
+       com::centreon::logging::engine::instance().is_log(                 \
+           com::centreon::logging::type_debug, verbose);                  \
        ++__com_centreon_logging_define_ui)                                \
   com::centreon::logging::temp_logger(com::centreon::logging::type_debug, \
                                       verbose)                            \
@@ -62,8 +58,8 @@ CC_END()
 #define log_error(verbose)                                                \
   for (unsigned int __com_centreon_logging_define_ui(0);                  \
        !__com_centreon_logging_define_ui &&                               \
-           com::centreon::logging::engine::instance().is_log(             \
-               com::centreon::logging::type_error, verbose);              \
+       com::centreon::logging::engine::instance().is_log(                 \
+           com::centreon::logging::type_error, verbose);                  \
        ++__com_centreon_logging_define_ui)                                \
   com::centreon::logging::temp_logger(com::centreon::logging::type_error, \
                                       verbose)                            \

inc/com/centreon/logging/syslogger.hh

@@ -54,7 +54,7 @@ class syslogger : public backend {
   int _facility;
   std::string _id;
 };
-}
+}  // namespace logging
 
 CC_END()
 

inc/com/centreon/logging/temp_logger.hh

@@ -21,8 +21,8 @@
 
 #include <string>
 #include "com/centreon/logging/engine.hh"
-#include "com/centreon/namespace.hh"
 #include "com/centreon/misc/stringifier.hh"
+#include "com/centreon/namespace.hh"
 
 CC_BEGIN()
 
@@ -59,7 +59,7 @@ class temp_logger {
   unsigned long long _type;
   unsigned int _verbose;
 };
-}
+}  // namespace logging
 
 CC_END()
 

inc/com/centreon/misc/argument.hh

@@ -67,7 +67,7 @@ class argument {
   char _name;
   std::string _value;
 };
-}
+}  // namespace misc
 
 CC_END()
 

inc/com/centreon/misc/command_line.hh

@@ -55,7 +55,7 @@ class command_line {
   char** _argv;
   size_t _size;
 };
-}
+}  // namespace misc
 
 CC_END()
 

inc/com/centreon/misc/get_options.hh

@@ -22,8 +22,8 @@
 #include <map>
 #include <string>
 #include <vector>
-#include "com/centreon/namespace.hh"
 #include "com/centreon/misc/argument.hh"
+#include "com/centreon/namespace.hh"
 
 CC_BEGIN()
 
@@ -74,7 +74,7 @@ class get_options {
                            std::string& key,
                            std::string& value);
 };
-}
+}  // namespace misc
 
 CC_END()
 

inc/com/centreon/misc/stringifier.hh

@@ -75,7 +75,7 @@ class stringifier {
   static unsigned int const _static_buffer_size = 1024;
   char _static_buffer[_static_buffer_size];
 };
-}
+}  // namespace misc
 
 CC_END()
 

inc/com/centreon/process.hh

@@ -20,7 +20,10 @@
 #define CC_PROCESS_POSIX_HH
 
 #include <sys/types.h>
+#include <array>
+#include <atomic>
 #include <condition_variable>
+#include <csignal>
 #include <mutex>
 #include <string>
 #include "com/centreon/timestamp.hh"
@@ -39,6 +42,24 @@ class process_manager;
 class process {
   friend class process_manager;
 
+  /* Constants */
+  const std::array<bool, 3> _enable_stream;
+  process_listener* const _listener;
+
+  /* Constants except during exec() call */
+  uint32_t _timeout;
+
+  /* Constants except when they are initialized at exec() and closed when
+   * process is over. */
+  std::atomic_bool _is_timeout;
+  std::atomic_int _status;
+  std::array<int, 3> _stream;
+  pid_t _process;
+
+  /* Almost never changed, we have two such functions, one with pgid and the
+   * other without. */
+  pid_t (*_create_process)(char**, char**);
+
  public:
   enum status { normal = 0, crash = 1, timeout = 2 };
   enum stream { in = 0, out = 1, err = 2 };
@@ -59,20 +80,12 @@ class process {
    *   method is called by the process manager in its main loop when needed.
    */
   std::string _buffer_out;
-  pid_t (*_create_process)(char**, char**);
   mutable std::condition_variable _cv_buffer_err;
   mutable std::condition_variable _cv_buffer_out;
   mutable std::condition_variable _cv_process_running;
-  const std::array<bool, 3> _enable_stream;
-  std::array<int, 3> _stream;
   timestamp _end_time;
-  bool _is_timeout;
-  process_listener* _listener;
   mutable std::mutex _lock_process;
-  pid_t _process;
   timestamp _start_time;
-  int _status;
-  uint32_t _timeout;
 
   static void _close(int& fd) noexcept;
   static pid_t _create_process_with_setpgid(char** args, char** env);
@@ -101,7 +114,7 @@ class process {
   void exec(std::string const& cmd, uint32_t timeout = 0);
   int exit_code() const noexcept;
   status exit_status() const noexcept;
-  void kill();
+  void kill(int sig = SIGKILL);
   void read(std::string& data);
   void read_err(std::string& data);
   void setpgid_on_exec(bool enable) noexcept;
@@ -110,9 +123,10 @@ class process {
   void terminate();
   void wait() const;
   bool wait(uint32_t timeout) const;
-  void update_ending_process(int status);
   uint32_t write(std::string const& data);
   uint32_t write(void const* data, uint32_t size);
+  void update_ending_process(int status);
+  void set_timeout(bool timeout);
 };
 
 CC_END()