Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile review after CI changes #1624

Merged
merged 13 commits into from
Nov 27, 2023
Merged

Dockerfile review after CI changes #1624

merged 13 commits into from
Nov 27, 2023

Conversation

gpmayorga
Copy link
Contributor

Removing some unnecessary lines on the Docker file and making everything more explicit

@gpmayorga
Dockerfile review after CI changes
c0863c7 
Removing some unnecessary lines on the Docker file and making everything more explicit
wischli
wischli previously approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing more clarity to this grey box.

@wischli wischli added D2-notify Pull request can be merged and notification about changes should be documented. D0-ready Pull request can be merged without special precaution and notification. P7-asap Issue should be addressed in the next days. I12-ci Issue related to CI and removed D2-notify Pull request can be merged and notification about changes should be documented. labels Nov 24, 2023
wischli
wischli previously approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving. Let's hope #1625 will fix the docs 😅

mustermeiszer
mustermeiszer approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@mustermeiszer mustermeiszer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on internal comms.

wischli
wischli approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@wischli wischli merged commit 1e65036 into main Nov 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustermeiszer mustermeiszer mustermeiszer approved these changes

@wischli wischli wischli approved these changes

Assignees
No one assigned
Labels
D0-ready Pull request can be merged without special precaution and notification. I12-ci Issue related to CI P7-asap Issue should be addressed in the next days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpmayorga @wischli @mustermeiszer