-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Improve logging and fix successful proxy execution check #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdamian
changed the title
api: Improve logging
api: Improve logging and fix successful proxy execution check
Dec 8, 2023
cdamian
force-pushed
the
centapi-improve-logging
branch
from
December 8, 2023 19:53
bc9043d
to
1b3d868
Compare
Will merge as soon as the latest centrifuge-chain image is fixed - centrifuge/centrifuge-chain#1644 and we can run the integration/testworld tests. |
cdamian
force-pushed
the
centapi-improve-logging
branch
from
December 11, 2023 10:55
1b3d868
to
de6a08f
Compare
cdamian
force-pushed
the
centapi-improve-logging
branch
from
December 11, 2023 11:16
de6a08f
to
e8556ae
Compare
lemunozm
previously approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as far as my Go knowledge is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.