-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cfg token functions #721
base: main
Are you sure you want to change the base?
Conversation
Deployed website in Google Cloud |
Passing to @gpmayorga to take over the finish line |
Deployed website in Google Cloud |
Finally getting to this now. hopefully ready in a week or so |
@jpangelle looking at the functions code here it seems the way this was developed is:
So I don't think it is a matter of pipeline deployments everything should work as it is even though the pipeline does need a bit of love but I'd rather not make this a priority if it works |
there's the SUBSCAN_API_KEY though, is that the same for all environments? Where do I get that value from? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the new function JS files will be deployed unless bundled up under the same function trigger. Website was designed to have only one function with some routing involved
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Deployed website in Google Cloud |
Description
This pull request adds two new functions:
#650