Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cfg token functions #721

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add cfg token functions #721

wants to merge 3 commits into from

Conversation

jpangelle
Copy link
Contributor

@jpangelle jpangelle commented Dec 11, 2023

Description

This pull request adds two new functions:

  • CFG circulating supply
  • CFG total issuance

#650

Copy link

Deployed website in Google Cloud
URL: http://preview-pr721.k-f.dev
Commit #: b7d7224

@jpangelle
Copy link
Contributor Author

Passing to @gpmayorga to take over the finish line

Copy link

Deployed website in Google Cloud
URL: http://preview-pr721.k-f.dev
Commit #: 582e1a0

@gpmayorga
Copy link
Collaborator

Finally getting to this now. hopefully ready in a week or so

@gpmayorga
Copy link
Collaborator

@jpangelle looking at the functions code here it seems the way this was developed is:

  • All of the code under functions/src are deployed as a single function in Google Cloud
  • There's a routes.json that contains the functions that need routing?
  • And they're also individually included in the esbuild.js

So I don't think it is a matter of pipeline deployments everything should work as it is even though the pipeline does need a bit of love but I'd rather not make this a priority if it works

@gpmayorga
Copy link
Collaborator

there's the SUBSCAN_API_KEY though, is that the same for all environments? Where do I get that value from?

Copy link
Collaborator

@gpmayorga gpmayorga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the new function JS files will be deployed unless bundled up under the same function trigger. Website was designed to have only one function with some routing involved

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] network Transitive: environment, filesystem +8 2.17 MB jasonsaayman

View full report↗︎

Copy link

Deployed website in Google Cloud
URL: http://preview-pr721.k-f.dev
Commit #: 34cf7c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants