Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update templates to support e2e for kubernetes 1.28 #4057

Merged
merged 2 commits into from
Aug 21, 2023
Merged

update templates to support e2e for kubernetes 1.28 #4057

merged 2 commits into from
Aug 21, 2023

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Aug 17, 2023 •
edited
Loading

Updated github action to run kubernetes 1.28 tests and also consider test result to merge the PR (via mergify)

depends-on #4056

closes #4052

@Madhu-1
ci: update pull request commentor for kube 1.28.0
cd1cd8b 
updating pull request commentor to
run tests with kubernetes 1.28.0

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
ci: update mergify rules for kube v1.28.0
63b4910 
updating mergify rules to consider kubernetes
v1.28.0 ci jobs.

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1 Madhu-1 requested review from a team August 17, 2023 08:04
@mergify mergify bot added the component/testing Additional test cases or CI work label Aug 17, 2023
@nixpanic
Copy link
Member

/test ci/centos/k8s-e2e-external-storage/1.28

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e-helm/k8s-1.28

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e/k8s-1.28

@nixpanic
Copy link
Member

Should we remove testing for Kubernetes 1.25? I guess that version is not maintained anymore since 1.28 is released?

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 17, 2023

@nixpanic as per official doc it's not reached eol yet https://kubernetes.io/releases/

@Madhu-1 Madhu-1 requested a review from nixpanic August 17, 2023 14:29
@Madhu-1 Madhu-1 linked an issue Aug 21, 2023 that may be closed by this pull request
update kubernetes dependency to 1.28 #4052
Closed
4 tasks
@nixpanic
Copy link
Member

@nixpanic as per official doc it's not reached eol yet https://kubernetes.io/releases/

Maybe we should consider testing with different Kubernetes versions for different branches? The GitHub Commenter action that we use with ok-to-test might be able to support comments depending on the branch? It would speed up the e2e a little, as test jobs for 4 Kubernetes versions will take quite some time (not sure if they can all run in parallel due to CI quota).

@nixpanic nixpanic added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Aug 21, 2023
@Madhu-1 Madhu-1 mentioned this pull request Aug 21, 2023
Closed
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 21, 2023

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023 •
edited
Loading

queue

🛑 The pull request has been merged manually

The pull request has been merged manually at 1098751

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 21, 2023

As the mergify configuration is changed, merging this one manually

@Madhu-1 Madhu-1 merged commit 1098751 into ceph:devel Aug 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riya-singhal31 riya-singhal31 riya-singhal31 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update kubernetes dependency to 1.28
3 participants
@Madhu-1 @nixpanic @riya-singhal31