Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent dataloss due to the concurrent RPC calls (occurrence is very low) #4970

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Prevent dataloss due to the concurrent RPC calls (occurrence is very low) #4970

merged 4 commits into from
Nov 21, 2024
+35 −13

Commits on Nov 21, 2024

  1. rbd: take lock on targetpath during node operation 

    We should not be dependent on the CO to ensure
that it will serialize the request instead of
that we need to have own internal locks to ensure
that we dont do concurrent operations for same
request.

Signed-off-by: Madhu Rajanna <[email protected]>
    @Madhu-1
    Madhu-1 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    38c0e64 View commit details
    Browse the repository at this point in the history

  2. cephfs: take lock on targetpath on node operation 

    We should not be dependent on the CO to ensure
that it will serialize the request instead of
that we need to have own internal locks to ensure
that we dont do concurrent operations for same
request.

Signed-off-by: Madhu Rajanna <[email protected]>
    @Madhu-1
    Madhu-1 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    38b0a4c View commit details
    Browse the repository at this point in the history

  3. cephfs: use os.Remove to remove directory 

    using os.RemoveAll will remove everything
in the director after the Umount we should
be using os.Remove only to remove the empty
directory

Signed-off-by: Madhu Rajanna <[email protected]>
    @Madhu-1
    Madhu-1 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ffa8eaf View commit details
    Browse the repository at this point in the history

  4. rbd: use os.Remove to remove directory 

    using os.RemoveAll will remove everything
in the director after the Umount we should
be using os.Remove only to remove the empty
directory

Signed-off-by: Madhu Rajanna <[email protected]>
    @Madhu-1
    Madhu-1 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    39cc628 View commit details
    Browse the repository at this point in the history