Prevent dataloss due to the concurrent RPC calls (occurrence is very low) (backport #4970) #4972
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
We should not be dependent on the CO to ensure that it will serialize the request instead of that we need to have own internal locks to ensure that we dont do concurrent operations for same request. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit b6bd8ca)
We should not be dependent on the CO to ensure that it will serialize the request instead of that we need to have own internal locks to ensure that we dont do concurrent operations for same request. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit 7cfeae5)
using os.RemoveAll will remove everything in the director after the Umount we should be using os.Remove only to remove the empty directory Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit cd09266)
using os.RemoveAll will remove everything in the director after the Umount we should be using os.Remove only to remove the empty directory Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit 00d252e)
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
Madhu-1
added
the
ready-to-merge
|
@Madhu-1 Thanks for merging this so quickly, and thanks for the backport to 3.12. 🫶 Is there an ETA for a new 3.12 release? This would allow us to let go of our own fork that we've been maintaining with this fix. 😅 |
|
@martin-helmich am back from PTO, I will do it tomorrow EOD. |
|
https://github.com/ceph/ceph-csi/releases/tag/v3.12.3 is the release, the images will get pushed in next 2 hours |
This PR includes series for commits for the following actions
Thanks to @martin-helmich @hensur and @Lucaber for the detailed analysis
fixes: #4966
This is an automatic backport of pull request #4970 done by Mergify.