[WIP][Testing]Flatten group snapshot #4973
Draft
+109
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rakshith R <[email protected]>
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Rakshith-R
added
WIP
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Signed-off-by: Rakshith R <[email protected]>
|
5 additional group snapshots are created and deleted successfully. |
Rakshith-R
force-pushed
the
flatten-group-snapshot
branch
5 times, most recently
from
d22ce45
to
234ae0c
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.31 |
|
E2E changes in this pr adds creation & deletion of additional volumegroupsnapshots.
|
This commit consolidates flatten logic checks for cloneDepth and snapshotLimit in PrepareVolumeForSnapshot. This allows the function to be called for both CreateSnapshot and CreateVolumeGroupSnapshot. Clone Depth check and flattening of grand parent image now occurs before creation of snapshot starts. This aligns better with how PVC-PVC clone and PVC-restore process occurs currently. Flattening the grandparent image once prevents flattening of every newly created snapshot. Snapshot in above para refers to k8s VolumeSnapshot (which is backed by a rbd image). Signed-off-by: Rakshith R <[email protected]>
Rakshith-R
force-pushed
the
flatten-group-snapshot
branch
3 times, most recently
from
4c35c58
to
8882254
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Rakshith-R
force-pushed
the
flatten-group-snapshot
branch
from
8882254
to
43cf95f
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Signed-off-by: Rakshith R <[email protected]>
Rakshith-R
force-pushed
the
flatten-group-snapshot
branch
from
43cf95f
to
5edecc9
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Provide some context for the reviewer
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)