Run: Adjust filter links

The "see similar runs" links we provide were worded poorly and spaced weirdly. Signed-off-by: Zack Cerza <[email protected]>
ceph · Aug 9, 2023 · b437ad2 · b437ad2
1 parent 3a30b59
commit b437ad2
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 18 deletions.
diff --git a/src/components/Link/index.jsx b/src/components/Link/index.jsx
@@ -2,7 +2,11 @@ import MuiLink from "@mui/material/Link";
 
 export default function Link(props) {
   return (
-    <MuiLink href={props.to} target="_blank">
+    <MuiLink
+      href={props.to}
+      target="_blank"
+      sx={props.sx}
+    >
       {props.children}
     </MuiLink>
   );

diff --git a/src/pages/Run/index.tsx b/src/pages/Run/index.tsx
@@ -1,11 +1,11 @@
+import { PropsWithChildren } from 'react'
 import { useQueryParams, StringParam, NumberParam } from "use-query-params";
-import { styled, useTheme } from "@mui/material/styles";
+import { styled } from "@mui/material/styles";
 import { useParams } from "react-router-dom";
 import Typography from "@mui/material/Typography";
 import Button from "@mui/material/Button";
 import ButtonGroup from "@mui/material/ButtonGroup";
 import { format } from "date-fns";
-import SourceBranch from "mdi-material-ui/SourceBranch";
 import { Helmet } from "react-helmet";
 
 import type { Run, RunParams } from "../../lib/paddles.d";
@@ -28,8 +28,17 @@ const Root = styled("div")(() => ({
   },
 }));
 
+type FilterLinkProps = {
+  to: string
+}
+
+const FilterLink = (props: PropsWithChildren<FilterLinkProps>) => (
+  <Link sx={{mx: 0.33}}>
+    {props.children}
+  </Link>
+);
+
 export default function Run() {
-  const theme = useTheme();
   const [params, setParams] = useQueryParams({
     status: StringParam,
     page: NumberParam,
@@ -55,20 +64,16 @@ export default function Run() {
         {name}
       </Typography>
       <div style={{ margin: "20px 0px" }}>
-        <Typography>See similar runs:</Typography>
-        <Link to={`/runs/?suite=${suite}&branch=${branch}`}>
-          <Typography>
-            suite {suite} and branch {branch}
-          </Typography>
-        </Link>
-        <Link to={`/runs/?branch=${branch}`}>
-          <Typography>
-            <SourceBranch style={{ color: theme.palette.text.primary }} />
-          </Typography>
-        </Link>
-        <Link to={`/runs/?date=${date}`}>
-          <Typography>scheduled on {date}</Typography>
-        </Link>
+        See runs with the same:
+        <FilterLink to={`/runs/?branch=${branch}`}>
+            branch
+        </FilterLink>
+        <FilterLink to={`/runs/?suite=${suite}&branch=${branch}`}>
+            suite and branch
+        </FilterLink>
+        <FilterLink to={`/runs/?date=${date}`}>
+          date
+        </FilterLink>
       </div>
       <ButtonGroup style={{ display: "flex", justifyContent: "center" }}>
         <Button