Job{,List}: Link to job archive directories #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://pulpito-ng-pr-37.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cj5c9j8fvntc73ct1jh0. |
zmc
changed the title
|
Maybe we can use an archive/folder icon which vertically aligns with the status icon above, like: |
|
Thanks for the feedback @kamoltat and @VallariAg! Let me know what you think of the latest commit. |
✅ Deploy Preview for pulpito ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
We could add path-browserify as a dependency and have access to Node.js' path module, but that's 15kb and this is four lines. Signed-off-by: Zack Cerza <[email protected]>
This is more helpful than linking directly to teuthology.log, which may not even exist yet. Signed-off-by: Zack Cerza <[email protected]>
And change the text to "Log Archive" Signed-off-by: Zack Cerza <[email protected]>
VallariAg
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more helpful than linking directly to teuthology.log, which may not even exist yet.