-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JobList: Hover on status col shows failure reason #38
Conversation
Your Render PR Server URL is https://pulpito-ng-pr-38.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cj5upas5kgrc7381u5bg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zmc
One minor thing, when the failure description gets a bit long you often end up with the failure looking like this:
I think the purpose of hover show failure reason is to save the user the hassle of clicking into the actual job and look at the failure reason
@kamoltat I chose an arbitrary 200-char limit to display before chopping the string, in order to avoid the tooltip from getting unreasonably large. Sounds like a larger number would be good - what do you think? |
@yuriw I would love your feedback on this as well |
@kamoltat ping |
@zmc The longest I've seen is 701 characters long. I think we can try 750 or 800? if it doesn't look to ugly |
This truncates the longer strings to 200 chars. Signed-off-by: Zack Cerza <[email protected]>
@kamoltat Thanks - re-pushed with the 800 char limit. |
✅ Deploy Preview for pulpito ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This truncates the longer strings to 200 chars.