Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobList: Hover on status col shows failure reason #38

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

zmc
Copy link
Member

@zmc zmc commented Aug 3, 2023

This truncates the longer strings to 200 chars.

@render
Copy link

render bot commented Aug 3, 2023

@kamoltat kamoltat self-requested a review August 9, 2023 14:13
@kamoltat kamoltat self-assigned this Aug 9, 2023
Copy link
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmc
One minor thing, when the failure description gets a bit long you often end up with the failure looking like this:

image

I think the purpose of hover show failure reason is to save the user the hassle of clicking into the actual job and look at the failure reason

@zmc
Copy link
Member Author

zmc commented Aug 9, 2023

@kamoltat I chose an arbitrary 200-char limit to display before chopping the string, in order to avoid the tooltip from getting unreasonably large. Sounds like a larger number would be good - what do you think?

@zmc
Copy link
Member Author

zmc commented Aug 9, 2023

@yuriw I would love your feedback on this as well

@zmc zmc added the feature New feature or request label Aug 11, 2023
@kamoltat kamoltat assigned zmc and unassigned kamoltat Aug 14, 2023
@zmc
Copy link
Member Author

zmc commented Aug 21, 2023

@kamoltat ping

@kamoltat
Copy link
Member

kamoltat commented Aug 23, 2023

@zmc The longest I've seen is 701 characters long. I think we can try 750 or 800? if it doesn't look to ugly

@kamoltat
Copy link
Member

tested with 800 char

image

This truncates the longer strings to 200 chars.

Signed-off-by: Zack Cerza <[email protected]>
@zmc
Copy link
Member Author

zmc commented Aug 23, 2023

@kamoltat Thanks - re-pushed with the 800 char limit.

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for pulpito ready!

Name Link
🔨 Latest commit 8892c9c
🔍 Latest deploy log https://app.netlify.com/sites/pulpito/deploys/64e6564b7763ef0008303ce4
😎 Deploy Preview https://deploy-preview-38--pulpito.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamoltat kamoltat merged commit 72e7ee5 into main Aug 30, 2023
7 checks passed
@kamoltat kamoltat deleted the fr-tooltip branch August 30, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants