Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages/Job/index.jsx: Add sanity check for started time #50

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

Devansh3712
Copy link
Member

@Devansh3712 Devansh3712 commented Aug 13, 2023

This PR solves #26 by adding a function to check whether a date is valid or not using isValid function of date-fns library. This function is further used in timeSince and returns N/A if the date is not valid.

@netlify
Copy link

netlify bot commented Aug 13, 2023

Deploy Preview for pulpito ready!

Name Link
🔨 Latest commit 63972b9
🔍 Latest deploy log https://app.netlify.com/sites/pulpito/deploys/64d907b2c497440008403f39
😎 Deploy Preview https://deploy-preview-50--pulpito.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Devansh3712 Devansh3712 self-assigned this Aug 13, 2023
@Devansh3712 Devansh3712 requested a review from zmc August 15, 2023 07:30
Copy link
Member

@zmc zmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@zmc zmc merged commit 0cfab49 into ceph:main Aug 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants