JobList: add Global Filter #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pulpito ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Very cool! I'm seeing a small bug where typing text into the search field resets any sorting was in place - think you'd be able to address that? |
This will allow to search across all fields of all rows, in job list. Signed-off-by: Vallari Agrawal <[email protected]>
VallariAg
force-pushed
the
job-filter
branch
from
5ead246
to
1f79d65
Compare
|
@zmc thank you for reviewing this! I fixed it so the previous sorting is preserved after global search. I also changed the UI so the search is always open on left side of the header - it makes the existing of the global search feature more obvious I hope. |
zmc
temporarily deployed
to
job-filter - pulpito-ng PR #86
Render
Destroyed
|
This looks great! |
zmc
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to search across all fields of all rows, in job list.
On a run pgae, click on the search icon at top right. There you can search for any data in the table (os type, job id, job description, task name, etc).
Here I searched for "post_upgrade_checks" and it filtered by task
fs.post_upgrade_checks. Run: https://deploy-preview-86--pulpito.netlify.app/runs/teuthology-2024-09-13_21:08:03-orch-squid-distro-default-smithi