Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use teuthology-kill command instead of teuthology.kill.main function #47

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

VallariAg
Copy link
Member

@VallariAg VallariAg commented Feb 12, 2024

To test this PR, setup teuthology-api inside the teuthology container.

  1. Add instructions in teuthology dockerfile to setup t-api inside the teuthology container:
SHELL ["/bin/bash", "-c"] 
WORKDIR /
RUN git clone -b use-kill-cmd https://github.com/ceph/teuthology-api && \
    cd /teuthology-api/ && \
    python3 -m venv venv && source ./venv/bin/activate && pip install -e . && \
    export TEUTHOLOGY_API_SERVER_PORT=8083 && \
    exit
WORKDIR /teuthology
....
  1. In docker-compose file, expose TEUTHOLOGY_API_SERVER_PORT for teuthology service:
teuthology:
   ports:
      - 8083:8083
  1. Start the containers
  2. exec into the teuthology container and run these commands:
cd /teuthology-api
source ./venv/bin/activate
<add your teuthology-api's .env file>
uvicorn teuthology_api.main:app --reload --port 8083 --host 0.0.0.0
  1. Schedule a run on /suite route, using the README payload.
  2. Then kill by pressing "Kill Run" button of pages/Run/index.tsx: Add kill run button pulpito-ng#51

Contribution Guidelines

To sign and test your commits, please refer to Contibution guidelines.

Checklist

Copy link
Member

@zmc zmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only suggestions are around variable naming.

src/teuthology_api/config.py Outdated Show resolved Hide resolved
src/teuthology_api/services/kill.py Outdated Show resolved Hide resolved
This commit also removes "--user" from schemas/base.py

Signed-off-by: Vallari Agrawal <[email protected]>
@zmc zmc merged commit 2927fc5 into main Feb 14, 2024
4 checks passed
@zmc zmc deleted the use-kill-cmd branch February 14, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants