Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/docker-compose: Move to new containers/ dir #1861

Closed
wants to merge 16 commits into from
Closed

docs/docker-compose: Move to new containers/ dir #1861

wants to merge 16 commits into from

Conversation

zmc
Copy link
Member

@zmc zmc commented Jun 27, 2023

The existing docker-compose work is being replaced by ceph-devstack.

@zmc zmc requested a review from kamoltat June 30, 2023 20:19
@zmc zmc marked this pull request as ready for review June 30, 2023 20:19
@zmc
Copy link
Member Author

zmc commented Jul 26, 2023

@kamoltat I just re-pushed after restoring the docker-compose functionality - please take a look when you've got time!

@kamoltat
Copy link
Member

kamoltat commented Aug 2, 2023 •
edited
Loading

@zmc Was testing out this and ran into an error during bootstrap:

"/bin/sh -c cd /teuthology && mkdir ../archive_dir && mkdir log && chmod +x /teuthology/bootstrap && PIP_INSTALL_FLAGS=\"-r requirements.txt\" ./bootstrap" did not complete successfully: exit code: 1

Here is the full traceback of the error:

https://paste.centos.org/view/99a36a5b

Since max shelf life for centos paste bin is 1 day here is another paste bin:

https://pastebin.com/QDh3KQcB

kamoltat
kamoltat reviewed Aug 2, 2023
View reviewed changes
containers/teuthology-dev/Dockerfile
COPY docs/docker-compose/teuthology/.teuthology.yaml /root
COPY docs/docker-compose/teuthology/teuthology.sh /
RUN mkdir -p /etc/ansible
COPY docs/docker-compose/teuthology/ansible_inventory/hosts /etc/ansible/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me why you are removing ansible files again?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably shouldn't have ever actually copied files from ceph-sepia-secrets.git into the container image; we should probably use a volume for this in docker-compose.yml. ceph-devstack doesn't currently have that feature, but it could be added.

@zmc
Copy link
Member Author

zmc commented Aug 2, 2023

@zmc Was testing out this and ran into an error during bootstrap:

"/bin/sh -c cd /teuthology && mkdir ../archive_dir && mkdir log && chmod +x /teuthology/bootstrap && PIP_INSTALL_FLAGS=\"-r requirements.txt\" ./bootstrap" did not complete successfully: exit code: 1

Here is the full traceback of the error:

paste.centos.org/view/99a36a5b

Since max shelf life for centos paste bin is 1 day here is another paste bin:

pastebin.com/QDh3KQcB

145.1       error: could not create 'build/lib/ansible_collections/community/aws/tests/integration/targets/sns/aliases': No space left on device
[...]
145.1 ERROR: Could not install packages due to an OSError: [Errno 28] No space left on device: '/tmp/pip-wheel-9ycfocbi'

@zmc
Copy link
Member Author

zmc commented Aug 8, 2023

@kamoltat thoughts on the latest updates?

@zmc
Copy link
Member Author

zmc commented Sep 1, 2023

@kamoltat Since we can't seem to get this merged, I think it might make more sense to close this PR, copy relevant bits into ceph-devstack.git, and let you maintain the docker-compose bits here.

@zmc
docs/docker-compose: Move to new containers/ dir
efead9f 
This work is being mostly replaced by
https://github.com/zmc/ceph-devstack. However, since that tool has
fairly strict requirements, let's try to preserve the docker-compose
functionality. It will still be useful for tests that don't require
OSDs.

Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers: Use secrets for SSH keys, not env vars
60b790f 
Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers/teuthology-dev: Remove ansible files
dab43db 
Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers/teuthology-dev: Shorten watchdog_interval
6d9a832 
Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers/teuthology-dev: Pin base image to focal
40ae524 
Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers/testnode: Install podman
04cb828 
To get a recent version we have to switch OSes.

Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers/testnode: Support nesting
5302038 
Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers/testnode: Use systemd
457c8d7 
Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers/testnode: Write /scratch_devs
1a26423 
Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers/testnode: Install pkgs for ceph tests
5bbcc5e 
Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers/testnode: Use raw osd_method
5c69d6a 
Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers/testnode: no_cgroups_split
8833b98 
Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers/teuthology-dev: Parametrize suite
eff288c 
Signed-off-by: Zack Cerza <[email protected]>
@zmc
test_locking: Tolerate CentOS Stream's versioning
78ddaa6 
It's not a problem functionally, so explicitly allow it in the unit
test.

Signed-off-by: Zack Cerza <[email protected]>
@zmc
containers/teuthology-dev: Specify a cephadm image
9e6108c 
I'm not certain why suites aren't settings this / how they work when
they don't, but for now main is fine.

Signed-off-by: Zack Cerza <[email protected]>
@zmc
Copy link
Member Author

zmc commented Nov 28, 2023

Closed in favor of #1892

@zmc zmc closed this Nov 28, 2023
@zmc zmc deleted the ceph-devstack branch November 28, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamoltat kamoltat kamoltat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmc @kamoltat