feat: flight SQL sdk #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1do
force-pushed
the
feat/flight-sql-sdk
branch
10 times, most recently
from
8e736fc to
780e241
Compare
dav1do
force-pushed
the
feat/flight-sql-sdk
branch
from
780e241 to
858cc8b
Compare
dav1do
force-pushed
the
feat/flight-sql-sdk
branch
2 times, most recently
from
f3f8f11 to
7ea609d
Compare
dav1do
force-pushed
the
feat/flight-sql-sdk
branch
from
04730d1 to
7803e0d
Compare
|
Looks good on my end - pulled and tried locally. |
mzkrasner
approved these changes
Nov 19, 2024
nathanielc
approved these changes
Nov 19, 2024
only targeting platforms that ceramic-one runs on currently
- integration tests are only run on ubuntu VM currently - still need to get artifacts in the right place to publish
need to figure out how to get the imports right with the generated code. might need to use a sub package or two side by side packages...or just learn more about typescript
pnpm was picking up target and a ton of extra things
this is more clear, plus we're actually using the N-API interface and not WASM
dav1do
force-pushed
the
feat/flight-sql-sdk
branch
from
cffb558 to
7f56ff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new
flight-sql-clientpackage that usesnapito generate N-API bindings for doing the grpc/protobuf flight things and communicating with the ceramic-one flight SQL server. Currently targets #30, which are things I encountered while implementing this and extracted as they're not exactly related.I'm planning to implement package publishing in a follow up branch. I could also use help figuring out the typescript package structure to see if we can add new files that are available. Currently,
napigeneratesindex.jsandindex.d.tsin the root, which can be overridden via the--jsand--dtsflags, but I haven't quite managed to get the build/exports quite right so far.packages/flight-sql-clientfolder, and the package tests are run which simply gets the version from the binary to make sure it's the appropriate architecture.binary-arch.nodefile. Thenapi artifactscommand will move files from a directory to the target packages (artifactsandnpm/*by default`).