Improve naming of Ruby constants: convert unacceptable characters to …

…'_' rather than omit them.

lib/persistent_enum.rb

@@ -76,7 +76,7 @@ def cache_constants(model, required_constants, name_attr: :name)
       # Set each value as a constant on this class. If reloading, only update if
       # it's changed.
       to_constant_name = ->(s){
-        value = s.strip.gsub(/[^\w\s-]/, '').underscore
+        value = s.strip.gsub(/[^\w\s-]/, '_').underscore
         return nil if value.blank?
         value.gsub!(/\s+/, '_')
         value.gsub!(/_{2,}/, '_')

lib/persistent_enum/version.rb

@@ -1,3 +1,3 @@
 module PersistentEnum
-  VERSION = "1.0.7"
+  VERSION = "1.0.8"
 end

test/unit/persistent_enum_test.rb

@@ -111,6 +111,25 @@ def test_requires_constants
     destroy_test_model(:test_requires_constant)
   end
 
+  def test_constant_naming
+    test_constants = {
+      "CamelCase"             => "CAMEL_CASE",
+      :Symbolic               => "SYMBOLIC",
+      "with.punctuation"      => "WITH_PUNCTUATION",
+      "multiple_.underscores" => "MULTIPLE_UNDERSCORES"
+    }
+
+    create_test_model(:test_constant_name, ->(t){ t.string :name }) do
+      PersistentEnum.cache_constants(self, test_constants.keys)
+    end
+
+    test_constants.each do |k, v|
+      assert_present(TestConstantName.const_get(v))
+    end
+
+    destroy_test_model(:test_constant_name)
+  end
+
   def test_enum_immutable
     assert_raises(ActiveRecord::ReadOnlyRecord) do
       TestPersistentEnum.create(name: "foo")