Fix pull-up setting on STM32

CL: Fix pull-up setting on STM32 PUBLISHED_FROM=d0e12a8068d247d608e24c49ccb4d61fb62127bf
cesanta · Feb 21, 2019 · dd403d6 · dd403d6
1 parent 67ffee0
commit dd403d6
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/fw/platforms/stm32/src/stm32_gpio.c b/fw/platforms/stm32/src/stm32_gpio.c
@@ -230,8 +230,8 @@ bool mgos_gpio_set_mode(int pin, enum mgos_gpio_mode mode) {
 bool mgos_gpio_set_pull(int pin, enum mgos_gpio_pull_type pull) {
   GPIO_TypeDef *regs = stm32_gpio_port_base(pin);
   if (regs == NULL) return false;
-  const uint32_t pin_num = STM32_PIN_NUM(pin);
-  uint32_t pupdr_msk = (3 << pin_num), pupdr_val = 0;
+  const uint32_t shift = STM32_PIN_NUM(pin) * 2;
+  uint32_t pupdr_val = 0;
   switch (pull) {
     case MGOS_GPIO_PULL_NONE:
       break;
@@ -244,7 +244,7 @@ bool mgos_gpio_set_pull(int pin, enum mgos_gpio_pull_type pull) {
     default:
       return false;
   }
-  MODIFY_REG(regs->PUPDR, pupdr_msk, (pupdr_val << pin_num));
+  MODIFY_REG(regs->PUPDR, (3 << shift), (pupdr_val << shift));
   return true;
 }