Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esp32): added option to add partition before app_0 #592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daadu
Copy link

@daadu daadu commented Dec 28, 2021

Some use-case for having partition before app_0:

  • storing factory data at fixed offset irrespective of flash size

@daadu
Copy link
Author

daadu commented Jan 12, 2022

Any update on this? should be renamed to ESP_IDF_EXTRA_PARTITION_BEFORE_APP ??

@rojer
Copy link
Collaborator

rojer commented Jan 12, 2022

storing factory data at fixed offset irrespective of flash size

ok, i understand the need. but there's still one problem here: the NVS size. if it ever needs to be changed, for whatever reason, it's a problem.
so, let's move it to the very top, even before nvs and OTA state, and call the variable something else... ESP_IDF_EXTRA_PARTITION_TOP, perhaps, but if you have a better name - feel free.

@daadu
Copy link
Author

daadu commented Jan 13, 2022

If we move this "extra part" at top - then if some one wants to configure it, he has to shift all three default offsets - NVS_ADDR, OTA_DATA_ADDR and APP_OFFSET. In current case only have to shift APP_OFFSET.

Maybe can keep this as well as add "TOP" one?

@daadu
Copy link
Author

daadu commented Jan 13, 2022

Or do you think this "shifting" should be handled by MGOS? That is a bit non-trivial - as have make sure that the offset is "aligned" as per ESP spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants