Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the list of roles when they're presented for selection #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aws_google_auth/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def pick_a_role(roles, aliases=None, account=None):
enriched_roles_tab.append([i + 1, role_property[0], role_property[1]])

while True:
print(tabulate(enriched_roles_tab, headers=['No', 'AWS account', 'Role'], ))
print(tabulate(sorted(enriched_roles_tab), headers=['No', 'AWS account', 'Role'], ))
prompt = 'Type the number (1 - {:d}) of the role to assume: '.format(len(enriched_roles))
choice = Util.get_input(prompt)

Expand All @@ -53,7 +53,7 @@ def pick_a_role(roles, aliases=None, account=None):
print("Invalid choice, try again.")
else:
while True:
for i, role in enumerate(filtered_roles):
for i, role in enumerate(sorted(filtered_roles)):
print("[{:>3d}] {}".format(i + 1, role))

prompt = 'Type the number (1 - {:d}) of the role to assume: '.format(len(filtered_roles))
Expand Down