Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-12386: Added uninstall --purge option to remove "everything" #103

Merged
merged 1 commit into from
Dec 18, 2024
Merged

ENT-12386: Added uninstall --purge option to remove "everything" #103

merged 1 commit into from
Dec 18, 2024

Conversation

olehermanse
Copy link
Member

@olehermanse olehermanse commented Dec 18, 2024 •
edited
Loading

Supercedes: #101

@victormlg @olehermanse
Made uninstall remove "everything"
bb19a4f 
Ticket: ENT-12386
Signed-off-by: Victor Moene <[email protected]>
Co-authored-by: Ole Herman Schumacher Elgesem <[email protected]>
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse olehermanse mentioned this pull request Dec 18, 2024
Closed
craigcomstock
craigcomstock approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it is fine for now. We should really fix the packages themselves if we can.

As far as I know rpm packages uninstall nicely, debs do not.

@olehermanse olehermanse changed the title ENT-12386: Made uninstall remove "everything" ENT-12386: Added uninstall --purge option to remove "everything" Dec 18, 2024
@olehermanse olehermanse merged commit a5c1588 into cfengine:master Dec 18, 2024
5 checks passed
@olehermanse olehermanse deleted the uninstall-purge branch December 18, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigcomstock craigcomstock craigcomstock approved these changes

@larsewi larsewi Awaiting requested review from larsewi

@victormlg victormlg Awaiting requested review from victormlg

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olehermanse @craigcomstock @victormlg