ENT-11158: cf-remote deploy now looks for masterfiles in current working directory #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcomstock
force-pushed
the
ENT-11158
branch
from
47a17ba to
0dae766
Compare
olehermanse
requested changes
Jan 8, 2024
Comment on lines
+810
to
+811
| if not masterfiles: | ||
| masterfiles = "." |
There was a problem hiding this comment.
I would add a print message similar to line 802 for this. Also, maybe we can perform some sanity check first? Maybe look for promises.cf?
There was a problem hiding this comment.
ok, here's what it does now:
Craigs-MacBook-Pro.local ? cf-remote deploy --hub vagrant@ubuntu-20
cf-remote: No cfbs or masterfiles policy set found
Craigs-MacBook-Pro.local ? cd cfe/play-cfbs/
Craigs-MacBook-Pro.local ? cf-remote deploy --hub vagrant@ubuntu-20
Found cfbs policy set: 'out/masterfiles.tgz'
Craigs-MacBook-Pro.local ? cd ../masterfiles/
Craigs-MacBook-Pro.local ? cf-remote deploy --hub vagrant@ubuntu-20
Found masterfiles policy set: '/Users/craig/cfe/masterfiles'
… use . Ticket: ENT-11158 Changelog: title
craigcomstock
force-pushed
the
ENT-11158
branch
from
0dae766 to
10b1e8a
Compare
olehermanse
changed the title
olehermanse
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: ENT-11158
Changelog: title