ENT-11138: proper error message when typing unsupported/unknown platform #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsewi
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
$ git checkout master
Already on 'master'
Your branch is up to date with 'origin/master'.
$ black --check cf_remote/spawn.py
All done! ✨ 🍰 ✨
1 file would be left unchanged.
$ gh pr checkout 83
Switched to branch 'ENT-11138'
$ black --check cf_remote/spawn.py
would reformat cf_remote/spawn.py
Oh no! 💥 💔 💥
1 file would be reformatted.
Nice! Feel free to format with black. But still approved if you chose not to ✅
olehermanse
requested changes
Mar 15, 2024
Ticket: ENT-11138 Changelog: None Signed-off-by: Mikita Pilinka <[email protected]>
|
Should be merged after #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of available platforms is printed when user inputs unknown platform
Ticket: ENT-11138
Changelog: None