Added --output-dir flag in download command #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehermanse
reviewed
Dec 11, 2024
cf_remote/commands.py
Outdated
| @@ -296,7 +296,7 @@ def _iterate_over_packages(tags=None, version=None, edition=None, download=False | |||
| else: | |||
| for artifact in artifacts: | |||
| if download: | |||
| download_package(artifact.url) | |||
| download_package(artifact.url, directory=output_dir) | |||
There was a problem hiding this comment.
Take a look at the ticket again. We want to keep downloading to the same place, and then copy once it's done downloading and also checksum is verified.
olehermanse
reviewed
Dec 12, 2024
olehermanse
reviewed
Dec 12, 2024
olehermanse
reviewed
Dec 12, 2024
cf_remote/commands.py
Outdated
Comment on lines
311
to
315
| tmp_filename = '.{}.tmp'.format(filename) | ||
| tmp_output_path = os.path.join(output_dir, tmp_filename) | ||
|
|
||
| shutil.copyfile(package_path, tmp_output_path) | ||
| os.rename(tmp_output_path, output_path) |
There was a problem hiding this comment.
@victormlg This logic (generate tmp filename, copy to temp file, rename) is generally useful. Maybe you could put these 4 lines into a new function, called copy_file in utils.py?
olehermanse
reviewed
Dec 18, 2024
cf_remote/utils.py
Outdated
| tmp_output_path = os.path.join(output_dir, tmp_filename) | ||
|
|
||
| shutil.copyfile(input_path, tmp_output_path) | ||
| os.rename(tmp_output_path, output_path) |
There was a problem hiding this comment.
Please add a newline (empty line) at the end of the file. That's what the red circle with minus means here in GitHub.
olehermanse
requested changes
Dec 18, 2024
Ticket: CFE-3684 Signed-off-by: Victor Moene <[email protected]>
olehermanse
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.