Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-4256: Fallback on /usr/bin/getent when /bin/getent does not exist #5329

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

amousset
Copy link
Contributor

@amousset amousset commented Sep 18, 2023

https://northerntech.atlassian.net/browse/CFE-4256

Still not tested. Now tested on a system where this error occurred.

@amousset amousset changed the title Fallback on /usr/bin/getent when /bin/getent does not exist CFE-4256: Fallback on /usr/bin/getent when /bin/getent does not exist Sep 18, 2023
@cf-bottom
Copy link

Thank you for submitting a PR! Maybe @olehermanse can review this?

@amousset amousset marked this pull request as ready for review October 25, 2023 13:44
vpodzime
vpodzime previously approved these changes Nov 20, 2023
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@vpodzime
Copy link
Contributor

I'll take care of making the commit (message) nicer. Thanks for the contribution, @amousset!

larsewi
larsewi previously approved these changes Nov 20, 2023
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

libpromises/unix.c Outdated Show resolved Hide resolved
Ticket: CFE-4256
Changelog: /usr/bin/getent is now attempted to be used if
           /bin/getent doesn't exist
@vpodzime vpodzime dismissed stale reviews from larsewi and themself via 08ae1d1 November 20, 2023 15:04
@vpodzime vpodzime merged commit ff6e951 into cfengine:master Nov 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants