Modify all calls to WriterWriteHelp to adapt to API change

[lluiscampos]

Merge together:
#5339
https://github.com/cfengine/nova/pull/2128

[lluiscampos]

Depends on:

• Modify help writer utility to take website and copyright as parameters NorthernTechHQ/libntech#194

[vpodzime]

Looks good to me otherwise. It will need changes in other CFEngine repos, but I can take care of that. Thanks!

[vpodzime]

@cf-bottom jenkins, please

[cf-bottom]

Alright, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/9937/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9937/

[olehermanse]

Great work, but looks like this needs at least a change in enterprise repo for windows to compile.

[vpodzime]

Great work, but looks like this needs at least a change in enterprise repo for windows to compile.

What do you mean @olehermanse? I see this:

ci/testing_pr/PACKAGES_i386_mingw — Build and tests finished: success
ci/testing_pr/PACKAGES_x86_64_mingw — Build and tests finished: success

[larsewi]

Windows packages don't seem to work. But I will take a look at it this week :)

[larsewi]

Tested, built together with https://github.com/cfengine/nova/pull/2130#issuecomment-1754585718. And it seems to work :)

[larsewi]

Merging can be performed automatically once the requested changes are addressed.

Not able to merge

[craigcomstock]

@lluiscampos @olehermanse did we really want to remove all the Commands: text from the help?

It used to be

$ /var/cfengine/bin/cf-check --help

cf-check:
        Utility for diagnosis and repair of local CFEngine databases.
        This BETA version of the tool is for testing purposes only.

Commands:
        dump - Print the contents of a database file
        diagnose - Assess the health of one or more database files
        backup - Copy database files to a timestamped folder
        repair - Diagnose, then backup and delete any corrupt databases
        version - Print version information
        help - Print this help menu

Usage:
        $ cf-check <command> [options] [file ...]

Examples:
        $ cf-check dump /var/cfengine/state/cf_lastseen.lmdb
        $ cf-check lmdump -a /var/cfengine/state/cf_lastseen.lmdb
        $ cf-check diagnose
        $ cf-check repair

But now is

$ cf-check --help
Usage: cf-check [OPTIONS] [FILE]

Options:
  --help        , -h value - Print the help message
  --manpage     , -M       - Print the man page
  --version     , -V       - Output the version of the software
  --debug       , -d       - Enable debugging output
  --verbose     , -v       - Enable verbose output
  --log-level   , -g value - Specify how detailed logs should be. Possible values: 'error', 'warning', 'notice', 'info', 'verbose', 'debug'
  --inform      , -I       - Enable basic information output

Website: https://cfengine.com
This software is Copyright 2023 Northern.tech AS.

Not quite as informative as it should be I think.

[lluiscampos]

@lluiscampos @olehermanse did we really want to remove all the Commands: text from the help?

Thanks for reporting.

The commands were indeed removed by mistake. See the follow-up in #5353. See discussion there for what happened to the examples.