Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-10993: Static checks now rebuilds container if run.sh is modified #5645

Merged
merged 3 commits into from
Dec 5, 2024
Merged

ENT-10993: Static checks now rebuilds container if run.sh is modified #5645

merged 3 commits into from
Dec 5, 2024

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Dec 3, 2024

No description provided.

@larsewi larsewi requested a review from craigcomstock December 3, 2024 14:47
@larsewi
Copy link
Contributor Author

larsewi commented Dec 3, 2024

@cf-bottom Jenkins please :)

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11469/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11469/

craigcomstock
craigcomstock requested changes Dec 3, 2024
View reviewed changes
tests/static-check/run.sh Outdated Show resolved Hide resolved
@larsewi larsewi marked this pull request as draft December 4, 2024 09:22
@larsewi larsewi added the WIP Work in Progress label Dec 4, 2024
@larsewi
Static checks now rebuilds image if run.sh is modified
9617b15 
Ticket: ENT-10993
Changelog: None
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi larsewi removed the WIP Work in Progress label Dec 5, 2024
@larsewi larsewi marked this pull request as ready for review December 5, 2024 13:24
@larsewi
Copy link
Contributor Author

larsewi commented Dec 5, 2024

Only static checks Build Status

@larsewi larsewi requested a review from craigcomstock December 5, 2024 13:26
craigcomstock
craigcomstock previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it!

@larsewi
Static checks now also rebuilds image on missing checksum
6cc3890 
Ticket: ENT-10993
Changelog: None
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
Copy link
Contributor Author

larsewi commented Dec 5, 2024

Let's try again (only static checks) Build Status

@larsewi
Don't create new container from new image
ace19ac 
The modified container created from the base image is identical.

Ticket: ENT-10993
Changelog: None
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
Copy link
Contributor Author

larsewi commented Dec 5, 2024

I made one more change Build Status (again only static checks)

@larsewi larsewi merged commit 74d100b into cfengine:master Dec 5, 2024
16 of 17 checks passed
@larsewi larsewi deleted the static branch December 18, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodzime vpodzime vpodzime left review comments

@craigcomstock craigcomstock craigcomstock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larsewi @cf-bottom @vpodzime @craigcomstock