Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted cf-support for exotic UNIX platforms #5652

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Dec 5, 2024

head -c 8 doesn't work on hpux 11.23 that we test on currently

dd count=1 bs=8 should work on all UNIX systems

tr on solaris needs LC_CTYPE=C as it can't handle binary data.
Silence not found sysctl command where it is not present.

Ticket: ENT-9786
Changelog: title

larsewi
larsewi previously approved these changes Dec 6, 2024
@craigcomstock craigcomstock force-pushed the ENT-9786/master branch 2 times, most recently from 04de793 to 647b54f Compare December 6, 2024 18:23
@craigcomstock craigcomstock changed the title Adjusted cf-support temp dir function to work on more UNIX platforms Adjusted cf-support for exotic UNIX platforms Dec 6, 2024
@craigcomstock
Copy link
Contributor Author

@cf-bottom please run cf-support tests (wish you knew how)

@cf-bottom
Copy link

@craigcomstock
Copy link
Contributor Author

Build Status

@craigcomstock
Copy link
Contributor Author

hpux testing-pr failure is fixed with cfengine/buildscripts#1546, retry: Build Status

larsewi
larsewi previously approved these changes Dec 9, 2024
head -c 8 doesn't work on hpux 11.23 that we test on currently

dd count=1 bs=8 should work on all UNIX systems

tr on solaris needs LC_CTYPE=C as it can't handle binary data.
Silence not found sysctl command where it is not present.

Ticket: ENT-9786
Changelog: title
@craigcomstock
Copy link
Contributor Author

another retry, should be OK, just want to double-check :)

Build Status

Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe squash the two last commits? Otherwise, LGTM 🚀

…s missing

Previously cf-support would fail if core dumps were present and gdb was missing.

We only want a warning and a log of which files are available for anlysis in this case.

Ticket: ENT-9786
Changelog: title
@craigcomstock craigcomstock merged commit bd34499 into cfengine:master Dec 12, 2024
12 checks passed
@craigcomstock craigcomstock deleted the ENT-9786/master branch December 12, 2024 18:57
@craigcomstock
Copy link
Contributor Author

cherry picks: #5665 and #5664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants