Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Triage existing linting issues #1060

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tanner-ricks
Copy link
Contributor

@tanner-ricks tanner-ricks commented Nov 14, 2024

Went through several linter issues and fixed most

Changes

  • Went through and found areas of easy linter improvements and fixed them.
  • Went through and found areas referencing this ticket and either fixed them, or put them under the umbrella of the post-mvp linter issues.

How to test this PR

  1. Pull the branch for the sbl-frontend repo
  2. Restart the stack as necessary
  3. Check the github pipeline and make sure that linters are green
  4. Run the e2e tests and verify no new failures

…ring

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@tanner-ricks tanner-ricks changed the title [Bug] Triage existing linting issues Draft: [Bug] Triage existing linting issues Nov 14, 2024
@tanner-ricks tanner-ricks marked this pull request as draft November 14, 2024 18:21
@tanner-ricks tanner-ricks marked this pull request as ready for review November 14, 2024 20:11
@tanner-ricks tanner-ricks changed the title Draft: [Bug] Triage existing linting issues [Bug] Triage existing linting issues Nov 14, 2024
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @tanner-ricks, and I'm fine with the exceptions you've included. Could you add exceptions / take a look at the 3 typescript errors in src/pages/Filing/ViewInstitutionProfile/index.tsx, since after that, all the linters should be passing again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants