Bugfix for #1595 / Annotation Data is inconsistent between Preview Player and Playlist Player #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates frame number on save to match player.js frame
…me offset to PreviewPlayer saved annotations to match player.js
Fixes offset framenumber on annotation in previewplayer - Bugfix cgwire#1595
This was referenced Dec 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Annotation frame number was off by one frame when saving from PreviewPlayer.vue compared to player.js
This is due to the annotation.js mixins calling it's parents getCurrentFrame() function. This is implemented differently in player.js and PreviewPlayer.vue and thus returning different numbers.
Solution
Adapt
getCurrentFrame()function in PreviewPlayer.vue to return the same number as the one in player.jsLimitation
player.js still returns a padded string as the framenumber whereas this patch returns an int.
Overall this might be a simplified patch - it would probably be better to align the two functions but I am not sure what else that might break.