Drawing Improvements | PSBrush Library for pressure sensitivity / Shortcuts to jump between drawings #1641
+2,244
−1,199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ramework for adding them to player mixin
…s is not live-updating currently, no idea why )
…d methods, removes unneccesary console logs. wip: step to next / previous frame in both player contexts
updates frame number on save to match player.js frame
…me offset to PreviewPlayer saved annotations to match player.js
Fixes offset framenumber on annotation in previewplayer - Bugfix cgwire#1595
…rints, added , and . shortcuts on playlist
|
Thank you! That is going to be well appreciated. Just a question: why did you use this library instead of the one that allows to chose different brushes? |
|
Sure! I checked the other libraries and I couldn't really find many others that support pressuresensitivity. I compared a few and found this to be the 'simplest':This library was:- simple ( easy to read / understand )- fewer features ( easier to maintain )- doesn't need extra GUI work- feels the same when used with a mouse- supports pressure sensitivity in a way that looked the easiest to implement into the current system without breaking existing features.- didn't need changes to how zou stores the serialised drawing data.- doesn't need opacity etc.Drawbacks:- github of the library dormant for a while now- only a single way of drawing / single brush- needed monkeypatching to work with the current cgwire/fabricWhat do you think? :)Von: Frank Rousseau ***@***.***>Gesendet: Dienstag, Dezember 31, 2024 1:52:03 PMAn: cgwire/kitsu ***@***.***>Cc: Tetsuo Animation ***@***.***>; Author ***@***.***>Betreff: Re: [cgwire/kitsu] Drawing Improvements | PSBrush Library for pressure sensitivity / Shortcuts to jump between drawings (PR #1641)
Thank you! That is going to be well appreciated.
Just a question: why did you use this library instead of the one that allows to chose different brushes?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Do you think that you can make your git history cleaner? It's a little bit hard to select the right commit to merge. |
| @@ -1815,15 +1809,15 @@ export default { | |||
| } else if (event.keyCode === 68) { | |||
| // d | |||
| this.container.focus() | |||
| this.pauseEvent(event) | |||
| this.pauseEvent(event)-1 //compensate for offsert frame number | |||
There was a problem hiding this comment.
This line doesn't make sense.
| this.onPencilAnnotateClicked() | ||
| } else if ((event.ctrlKey || event.metaKey) && event.keyCode === 90) { | ||
| // ctrl + z | ||
| this.undoLastAction() | ||
| } else if (event.altKey && event.keyCode === 82) { | ||
| // alt + r | ||
| this.redoLastAction() | ||
| } else if (event.altKey && event.keyCode === 74) { | ||
| } else if (event.altKey && event.keyCode === 74) {-1 // compensate for offset frame number |
There was a problem hiding this comment.
This line doesn't make sense.
|
It seems like merging main went wrong somewhere - I'll get this fixed when I'm back on Monday.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no pressure sensitivity when drawing with a pen
There is no way to jump between drawings
Solution
Implement PSBrush library
Implement , and . to jump between drawings
Note
This might need changes from my end or might not be what you need. Feel free to reject.
After updating to the latest main from cgwire/kitsu, the playlists break, but it seems like that might come from a new feature / other problem in PictureViewer ( I can't verify that currently )