Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to glycan parsing #219

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Minor fixes to glycan parsing #219

merged 4 commits into from
Dec 6, 2024

Conversation

wukevin
Copy link
Contributor

@wukevin wukevin commented Dec 6, 2024

Description

Misc. minor fixes for glycan parsing

  • Recognize arbitrary CCD codes when parsing glycans
  • Glycans should always be tokenized per atom
  • Improve logging and error messages.

Motivation

Fixes #218

Test plan

Added new test; test passes.

@wukevin wukevin requested a review from jackdent December 6, 2024 01:33
@wukevin wukevin merged commit 3278943 into main Dec 6, 2024
4 checks passed
@wukevin wukevin deleted the kevin/fix-parsing branch December 6, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glycan issue
1 participant