Merge pull request #589 from chainbound/fix/cli/parse-errors

fix(cli): remove default --chain in bolt delegate command
chainbound · Dec 17, 2024 · 6d0f407 · 6d0f407
2 parents 0fcebe3 + 04f0b4b
commit 6d0f407
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/bolt-cli/src/cli.rs b/bolt-cli/src/cli.rs
@@ -72,7 +72,7 @@ pub struct DelegateCommand {
     pub out: String,
 
     /// The chain for which the delegation message is intended.
-    #[clap(long, env = "CHAIN", default_value = "mainnet")]
+    #[clap(long, env = "CHAIN")]
     pub chain: Chain,
 
     /// The action to perform. The tool can be used to generate

diff --git a/bolt-sidecar/src/client/constraints.rs b/bolt-sidecar/src/client/constraints.rs
@@ -130,6 +130,7 @@ impl BuilderApi for ConstraintsClient {
         if self.delegations.is_empty() {
             return Ok(());
         }
+
         let validator_pubkeys =
             registrations.iter().map(|r| &r.message.public_key).collect::<HashSet<_>>();
 

diff --git a/bolt-sidecar/src/client/execution.rs b/bolt-sidecar/src/client/execution.rs
@@ -1,12 +1,11 @@
 use std::ops::{Deref, DerefMut};
 
-use alloy::rpc::client::RpcClient;
 use alloy::{
     eips::BlockNumberOrTag,
     primitives::{Address, Bytes, TxHash, B256, U256, U64},
     providers::{ProviderBuilder, RootProvider},
     rpc::{
-        client::{BatchRequest, ClientBuilder},
+        client::{BatchRequest, ClientBuilder, RpcClient},
         types::{Block, FeeHistory, TransactionReceipt},
     },
     transports::{http::Http, TransportErrorKind, TransportResult},

diff --git a/bolt-sidecar/src/driver.rs b/bolt-sidecar/src/driver.rs
@@ -412,11 +412,11 @@ impl<C: StateFetcher, ECDSA: SignerECDSA> SidecarDriver<C, ECDSA> {
         };
 
         let constraints = Arc::new(template.signed_constraints_list.clone());
-        let constraints_client = self.constraints_client.clone();
+        let constraints_client = Arc::new(self.constraints_client.clone());
 
         // Submit constraints to the constraints service with an exponential retry mechanism.
         tokio::spawn(retry_with_backoff(10, move || {
-            let constraints_client = constraints_client.clone();
+            let constraints_client = Arc::clone(&constraints_client);
             let constraints = Arc::clone(&constraints);
             async move {
                 match constraints_client.submit_constraints(constraints.as_ref()).await {