chore(sidecar): bump reth/alloy types, remove trace call manager #141
Conversation
WalkthroughThe changes significantly improve the organization and clarity of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
thedevbirb
force-pushed
the
chore/sidecar/bump-types-version
branch
from
5ff45cd to
30885d2
Compare
|
Tested also locally with the devnet:
Before merging this, we need self built with blob preconf working on unstable |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files ignored due to path filters (1)
bolt-sidecar/Cargo.lockis excluded by!**/*.lock
Files selected for processing (22)
- bolt-sidecar/Cargo.toml (2 hunks)
- bolt-sidecar/bin/sidecar.rs (1 hunks)
- bolt-sidecar/src/builder/compat.rs (1 hunks)
- bolt-sidecar/src/builder/mod.rs (3 hunks)
- bolt-sidecar/src/builder/payload_builder.rs (3 hunks)
- bolt-sidecar/src/builder/signature.rs (1 hunks)
- bolt-sidecar/src/builder/template.rs (1 hunks)
- bolt-sidecar/src/client/commit_boost.rs (1 hunks)
- bolt-sidecar/src/client/pubsub.rs (2 hunks)
- bolt-sidecar/src/client/rpc.rs (4 hunks)
- bolt-sidecar/src/common.rs (1 hunks)
- bolt-sidecar/src/config/chain.rs (1 hunks)
- bolt-sidecar/src/config/mod.rs (1 hunks)
- bolt-sidecar/src/crypto/bls.rs (1 hunks)
- bolt-sidecar/src/json_rpc/api.rs (1 hunks)
- bolt-sidecar/src/primitives/commitment.rs (1 hunks)
- bolt-sidecar/src/primitives/constraint.rs (1 hunks)
- bolt-sidecar/src/primitives/mod.rs (9 hunks)
- bolt-sidecar/src/state/execution.rs (2 hunks)
- bolt-sidecar/src/state/fetcher.rs (1 hunks)
- bolt-sidecar/src/state/head_tracker.rs (1 hunks)
- bolt-sidecar/src/test_util.rs (1 hunks)
Additional comments not posted (35)
bolt-sidecar/src/client/pubsub.rs (3)
6-11: LGTM! Import restructuring enhances clarity.The consolidation of
alloyimports improves readability and maintainability.
17-17: LGTM! Struct definition updated to align with the new module structure.The
PubsubClientstruct now usesalloyClient::RpcClient<PubSubFrontend>, reflecting the reorganization within thealloylibrary.
32-32: LGTM! Deref implementation updated to match the new struct definition.The
Derefimplementation now usesalloyClient::RpcClient<PubSubFrontend>, ensuring consistency with the updated struct definition.bolt-sidecar/Cargo.toml (3)
22-22: LGTM! Consolidation of Alloy dependencies simplifies management.The single entry for the
alloypackage with specific features (full,provider-trace-api,rpc-types-beacon,rpc-types-engine) reduces redundancy and enhances maintainability.
28-29: LGTM! Update to versioned Reth dependencies promotes stability.The
reth-primitivesandreth-rpc-layerdependencies now use version1.0.2, enhancing stability and predictability in builds.
62-62: LGTM! Update to Alloy node bindings enhances compatibility.The
alloy-node-bindingsdependency is now at version0.2.0, reflecting enhancements or changes in the bindings that interface with Alloy.bolt-sidecar/src/common.rs (1)
1-1: LGTM! Import statement updated to reflect module restructuring.The import statement for
U256now usesalloy::primitives::U256, ensuring compatibility with the updated module structure of thealloylibrary.bolt-sidecar/src/state/head_tracker.rs (1)
3-3: LGTM! Import path updated correctly.The import path for
HeadEventhas been updated to reflect the new module hierarchy in thealloylibrary.bolt-sidecar/src/crypto/bls.rs (1)
1-1: LGTM! Import path updated correctly.The import path for
FixedByteshas been updated to reflect the new module hierarchy in thealloylibrary.bolt-sidecar/src/client/commit_boost.rs (1)
3-3: LGTM! Import paths updated correctly.The import paths for
BlsPublicKeyandBlsSignaturehave been updated to reflect the new module hierarchy in thealloylibrary.bolt-sidecar/src/primitives/constraint.rs (1)
1-1: LGTM!The import path has been correctly updated to align with the new module structure.
bolt-sidecar/src/config/chain.rs (1)
3-3: LGTM!The import path has been correctly updated to align with the new module structure.
bolt-sidecar/src/builder/signature.rs (1)
1-1: LGTM!The import path has been correctly updated to align with the new module structure.
bolt-sidecar/src/test_util.rs (1)
1-10: LGTM! Import restructuring enhances code clarity.The consolidation of imports under the
alloynamespace improves readability and maintainability.bolt-sidecar/src/primitives/commitment.rs (1)
4-4: LGTM! Import path modification reflects better module organization.The update to the import path aligns with the restructuring of the
alloylibrary, improving code organization.bolt-sidecar/src/builder/mod.rs (3)
1-1: LGTM! Import path modification reflects better module organization.The update to the import path aligns with the restructuring of the
alloylibrary, improving code organization.
50-50: LGTM! Update toTransporterror variant aligns with new import structure.The update reflects a refactor of the transport-related error handling, improving code organization.
Line range hint
14-15:
Acknowledge deprecation ofstate_rootandcall_trace_managermodules.The deprecation of these modules helps streamline the codebase. Ensure to follow up and remove these modules once they are no longer needed.
Also applies to: 17-17
bolt-sidecar/bin/sidecar.rs (1)
3-3: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all references to
HeadEventare updated to reflect the new import path.Verification successful
All references to
HeadEventhave been successfully updated.The transition to the new import path
alloy::rpc::types::beacon::events::HeadEventis correctly implemented throughout the codebase.
bolt-sidecar/src/state/head_tracker.rsbolt-sidecar/bin/sidecar.rsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `HeadEvent` are updated to reflect the new import path. # Test: Search for the usage of `HeadEvent`. Expect: Only occurrences of the new import path. rg --type rust -A 5 $'HeadEvent'Length of output: 3022
bolt-sidecar/src/state/fetcher.rs (1)
7-11: Refactored import statements for better readability.The imports from the
alloycrate are now grouped under a singleuse alloy::{...}statement. This enhances readability and maintains clarity regarding the origin of the imported entities.bolt-sidecar/src/builder/compat.rs (1)
1-7: Refactored import statements for better readability.The imports from the
alloylibrary are now consolidated under a singleuse alloy::{...}statement. This approach enhances readability by grouping related imports and streamlines the import process.bolt-sidecar/src/json_rpc/api.rs (3)
27-27: Update toSignaturevariant inApiError.The
Signaturevariant has been updated to usealloy::primitives::SignatureError. Ensure that this change aligns with the updated library structure and that all references to this error type are updated accordingly.
31-31: Update toRlpvariant inApiError.The
Rlpvariant has been updated to usealloy::transports::HttpError. This change indicates a shift in how RLP decoding errors are handled, potentially associating them with HTTP transport errors. Verify that this change aligns with the new error handling strategy.
Line range hint
72-72: Verify error handling inrequest_inclusion_commitment.Ensure that the function correctly handles the updated
ApiErrorvariants, especially theSignatureandRlperrors.bolt-sidecar/src/config/mod.rs (1)
3-3: Update toAddressimport.The import statement for
Addresshas been updated toalloy::primitives::Address. Ensure that this change aligns with the updated library structure and that all references toAddressare updated accordingly.bolt-sidecar/src/builder/template.rs (1)
9-9: Update toAddressandU256imports.The import paths for
AddressandU256have been updated toalloy::primitives::{Address, U256}. Ensure that this change aligns with the updated library structure and that all references to these types are updated accordingly.bolt-sidecar/src/client/rpc.rs (2)
10-24: LGTM! Import statements are well organized.The reorganization of import statements under a structured namespace improves clarity and maintainability.
33-33: LGTM! But verify the function usage in the codebase.The changes to the
RpcClientstruct and theDerefandDerefMutimplementations are consistent and correct.However, ensure that all function calls to
RpcClientmatch the new struct definition.Also applies to: 211-213
Verification successful
LGTM! But verify the function usage in the codebase.
The changes to the
RpcClientstruct and theDerefandDerefMutimplementations are consistent and correct. The function calls toRpcClientmatch the new struct definition.
bolt-sidecar/src/client/rpc.rs:RpcClientis correctly instantiated and used.bolt-sidecar/src/builder/payload_builder.rs:RpcClientis correctly instantiated and used.bolt-sidecar/src/state/fetcher.rs:RpcClientis correctly instantiated and used.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `RpcClient` match the new struct definition. # Test: Search for the function usage. Expect: Only occurrences of the new struct definition. rg --type rust -A 5 $'RpcClient'Length of output: 6467
bolt-sidecar/src/primitives/mod.rs (2)
Line range hint
6-20:
LGTM! Import statements are well organized.The reorganization of import statements improves readability and maintainability.
233-233: LGTM! But verify the function usage in the codebase.The changes to the
TransactionExttrait and its implementation are consistent and correct.However, ensure that all function calls to
tx_kindmatch the new return type.Also applies to: 271-279
bolt-sidecar/src/builder/payload_builder.rs (3)
1-5: LGTM! Import statements are well organized.The reorganization of import statements under a single
use alloystatement improves readability and maintainability.
193-193: LGTM! But verify the usage of the new fields.The addition of the
requestsandrequests_rootfields enhances the data structure's capability to handle request-related information.However, ensure that the new fields are correctly initialized and used throughout the codebase.
Also applies to: 387-387
394-400: LGTM! But verify the test coverage.The addition of new test cases is approved.
However, ensure that the new test cases are comprehensive and cover all necessary scenarios.
bolt-sidecar/src/state/execution.rs (2)
1-5: LGTM! Import statements have been consolidated for better readability.Consolidating the import statements under a single
use alloystatement enhances readability and organization. This change aligns with common Rust practices for organizing module imports.
441-448: LGTM! Import statements in the test module have been restructured for consistency.Applying the same restructuring to the test module enhances consistency across the file and reduces cognitive load for developers reading the code.
thedevbirb
force-pushed
the
chore/sidecar/bump-types-version
branch
from
30885d2 to
2b78f6e
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files ignored due to path filters (1)
bolt-sidecar/Cargo.lockis excluded by!**/*.lock
Files selected for processing (22)
- bolt-sidecar/Cargo.toml (2 hunks)
- bolt-sidecar/bin/sidecar.rs (1 hunks)
- bolt-sidecar/src/builder/compat.rs (1 hunks)
- bolt-sidecar/src/builder/mod.rs (3 hunks)
- bolt-sidecar/src/builder/payload_builder.rs (3 hunks)
- bolt-sidecar/src/builder/signature.rs (1 hunks)
- bolt-sidecar/src/builder/template.rs (1 hunks)
- bolt-sidecar/src/client/commit_boost.rs (1 hunks)
- bolt-sidecar/src/client/pubsub.rs (2 hunks)
- bolt-sidecar/src/client/rpc.rs (4 hunks)
- bolt-sidecar/src/common.rs (1 hunks)
- bolt-sidecar/src/config/chain.rs (1 hunks)
- bolt-sidecar/src/config/mod.rs (1 hunks)
- bolt-sidecar/src/crypto/bls.rs (1 hunks)
- bolt-sidecar/src/json_rpc/api.rs (1 hunks)
- bolt-sidecar/src/primitives/commitment.rs (1 hunks)
- bolt-sidecar/src/primitives/constraint.rs (1 hunks)
- bolt-sidecar/src/primitives/mod.rs (9 hunks)
- bolt-sidecar/src/state/execution.rs (2 hunks)
- bolt-sidecar/src/state/fetcher.rs (1 hunks)
- bolt-sidecar/src/state/head_tracker.rs (1 hunks)
- bolt-sidecar/src/test_util.rs (1 hunks)
Additional comments not posted (40)
bolt-sidecar/src/client/pubsub.rs (5)
6-11: LGTM! Import reorganization enhances readability.The consolidation of
alloyimports into a single block improves clarity and maintainability.
17-17: LGTM! Struct definition update aligns with API reorganization.The update from
alloy::RpcClient<PubSubFrontend>toalloyClient::RpcClient<PubSubFrontend>aligns with the reorganization of thealloycrate's API.
Line range hint
21-28:
LGTM!newfunction correctly handles URL parsing and client creation.The function correctly parses the URL and creates a new
PubsubClientinstance.
32-34: LGTM!Derefimplementation update ensures consistency.The update to
alloyClient::RpcClient<PubSubFrontend>ensures consistent dereferencing behavior with the updated struct definition.
Line range hint
36-38:
LGTM!DerefMutimplementation correctly provides mutable access.The implementation correctly provides mutable access to the
RpcClient.bolt-sidecar/Cargo.toml (4)
22-22: LGTM! Alloy dependency consolidation simplifies structure.The consolidation of multiple Alloy-related dependencies into a single entry simplifies the dependency structure and enhances modularity and usability.
28-28: LGTM!reth-primitivesdependency update improves stability.The update from a commit-based specification to a versioned one improves stability and predictability in builds.
29-29: LGTM!reth-rpc-layerdependency update improves stability.The update from a commit-based specification to a versioned one improves stability and predictability in builds.
62-62: LGTM!alloy-node-bindingsdependency update likely includes improvements.The update from version
0.1.1to0.2.0likely includes improvements or changes in the bindings that interact with the Alloy framework.bolt-sidecar/src/common.rs (1)
1-1: LGTM! Import statement update aligns with module reorganization.The update from
alloy_primitivestoalloy::primitivesaligns with the reorganization within thealloylibrary's module structure.bolt-sidecar/src/state/head_tracker.rs (1)
3-3: LGTM! Verify the impact of the import path change.The import path for
HeadEventhas been updated to reflect the new module structure in thealloylibrary. Ensure that all references toHeadEventin the codebase are updated accordingly.Verification successful
The import path change for
HeadEventhas been correctly applied throughout the codebase.The references to
HeadEventin the filesbolt-sidecar/src/state/head_tracker.rsandbolt-sidecar/bin/sidecar.rshave been updated to use the new import pathalloy::rpc::types::beacon::events::HeadEvent.
bolt-sidecar/src/state/head_tracker.rs: Multiple references updated.bolt-sidecar/bin/sidecar.rs: Multiple references updated.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `HeadEvent` in the codebase. # Test: Search for the usage of `HeadEvent`. Expect: Only occurrences of the new import path. rg --type rust -A 5 $'HeadEvent'Length of output: 3022
bolt-sidecar/src/crypto/bls.rs (1)
1-1: LGTM! Verify the impact of the import path change.The import path for
FixedByteshas been updated to reflect the new module structure in thealloylibrary. Ensure that all references toFixedBytesin the codebase are updated accordingly.Verification successful
The import path change for
FixedBytesis correctly reflected.The new import path for
FixedBytesis correctly used inbolt-sidecar/src/crypto/bls.rs, and there are no other references toFixedBytesin the codebase that need updating.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `FixedBytes` in the codebase. # Test: Search for the usage of `FixedBytes`. Expect: Only occurrences of the new import path. rg --type rust -A 5 $'FixedBytes'Length of output: 877
Script:
#!/bin/bash # Description: Verify all references to `FixedBytes` in the codebase. # Test: Search for the usage of `FixedBytes` in the entire codebase. rg --type rust 'FixedBytes'Length of output: 160
bolt-sidecar/src/primitives/constraint.rs (1)
1-1: Update import path foralloy_primitives.The import path has been updated to
alloy::primitives, which likely reflects a restructuring within thealloylibrary. This change enhances code readability and maintainability by aligning with the new module hierarchy.bolt-sidecar/src/config/chain.rs (1)
3-3: Update import path forb256.The import path has been updated to
alloy::primitives::b256, which likely reflects a restructuring within thealloylibrary. This change enhances code readability and maintainability by aligning with the new module hierarchy.bolt-sidecar/src/builder/signature.rs (1)
1-1: Update import paths forBLS_DST_SIGandBlsSignature.The import paths have been updated to
alloy::rpc::types::beacon::{constants::BLS_DST_SIG, BlsSignature}, which likely reflects a restructuring within thealloylibrary. This change enhances code readability and maintainability by aligning with the new module hierarchy.bolt-sidecar/src/test_util.rs (1)
1-10: LGTM! Consolidated import statements improve readability and maintainability.The new structure reduces redundancy and provides a clearer overview of dependencies.
bolt-sidecar/src/primitives/commitment.rs (1)
4-4: LGTM! Updated import path reflects the new module hierarchy.The change aligns with the updated structure of the
alloylibrary.bolt-sidecar/src/builder/mod.rs (3)
1-1: LGTM! Updated import path reflects the new module hierarchy.The change aligns with the updated structure of the
alloylibrary.
1-1: Ensure proper communication of deprecated modules.The
state_rootandcall_trace_managermodules are marked as deprecated. Ensure this is properly communicated to all relevant stakeholders.
50-50: LGTM! UpdatedTransporterror variant reflects the new module hierarchy.The change aligns with the updated structure of the
alloylibrary.bolt-sidecar/bin/sidecar.rs (1)
3-3: LGTM! Ensure all references toHeadEventare updated.The import statement has been correctly updated to reflect the new module structure in the
alloylibrary.bolt-sidecar/src/state/fetcher.rs (1)
7-11: LGTM! The consolidated import statements enhance readability.The new format groups related imports together, improving code organization without changing functionality.
bolt-sidecar/src/builder/compat.rs (1)
1-7: LGTM! The consolidated import statements enhance readability.The new format groups related imports together, improving code organization without changing functionality.
bolt-sidecar/src/json_rpc/api.rs (2)
27-27: LGTM! Verify the import path forSignatureError.The
Signaturevariant's type has been updated correctly. Ensure thatalloy::primitives::SignatureErroris the correct import path.
31-31: LGTM! Verify the new type forRlpvariant.The
Rlpvariant's type has been updated correctly. Ensure thatalloy::transports::HttpErroris the correct type.bolt-sidecar/src/config/mod.rs (1)
3-3: LGTM! Verify the import path forAddress.The import statement for
Addresshas been updated correctly. Ensure thatalloy::primitives::Addressis the correct import path.bolt-sidecar/src/builder/template.rs (1)
9-9: LGTM! Verify the import path forAddressandU256.The import statement for
AddressandU256has been updated correctly. Ensure thatalloy::primitives::{Address, U256}is the correct import path.Verification successful
Verified! The import path for
AddressandU256is correct.The import statement
use alloy::primitives::{Address, U256};is used consistently across the codebase, confirming its correctness.
bolt-sidecar/src/builder/template.rsbolt-sidecar/src/config/mod.rsbolt-sidecar/src/primitives/commitment.rsbolt-sidecar/src/state/execution.rsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the import path for `Address` and `U256`. # Test: Search for the `Address` and `U256` definitions. Expect: Correct import path. rg --type rust 'Address' rg --type rust 'U256'Length of output: 9214
bolt-sidecar/src/client/rpc.rs (4)
10-24: LGTM! Import reorganization enhances readability.The restructuring of import statements creates a clearer hierarchy and improves maintainability.
33-33: LGTM! Struct definition updated to reflect new import structure.The
RpcClientstruct's definition now aligns with the new module organization.
211-211: LGTM!Derefimplementation updated to reflect new struct definition.The
Dereftrait implementation now aligns with the updatedRpcClientstruct definition.
Line range hint
215-217:
LGTM!DerefMutimplementation updated to reflect new struct definition.The
DerefMuttrait implementation now aligns with the updatedRpcClientstruct definition.bolt-sidecar/src/primitives/mod.rs (3)
Line range hint
6-20:
LGTM! Import consolidation enhances readability.The consolidation of import statements from the
reth_primitivesmodule improves readability and maintainability.
241-241: LGTM! Return type change enhances type safety.The return type change from
TransactionKindtoTxKindenhances type safety and semantic clarity.
279-287: LGTM! Implementation refinement improves transaction handling.The update to use
TxKind::Callfor theBlobTransactionvariant ensures a more deliberate handling of transaction types.bolt-sidecar/src/builder/payload_builder.rs (4)
1-5: LGTM! Import reorganization enhances readability.The restructuring of import statements creates a clearer hierarchy and improves maintainability.
198-198: LGTM! New fields enhance extensibility.The addition of
requestsandrequests_rootfields suggests an intention to accommodate request-related data, enhancing the extensibility of the payload builder.
391-391: LGTM! Addition ofrequests_rootfield improves context handling.The addition of the
requests_rootfield enhances the function's ability to handle additional contextual information related to requests.
398-404: LGTM! Import additions for tests are necessary.The addition of import statements for the
alloylibrary is necessary for the tests to function correctly.bolt-sidecar/src/state/execution.rs (2)
1-5: Improved import organization.The import statements have been consolidated and restructured, enhancing readability and maintainability. Ensure that the new paths are correct and consistent with the reorganization of the
alloymodule.
456-463: Consistent import restructuring in test module.The same restructuring applied to the main module is reflected in the test module, ensuring consistency across the file.
| @@ -1,6 +1,6 @@ | |||
| use std::sync::Arc; | |||
|
|
|||
| use alloy_rpc_types_beacon::{BlsPublicKey, BlsSignature}; | |||
| use alloy::rpc::types::beacon::{BlsPublicKey, BlsSignature}; | |||
There was a problem hiding this comment.
Tip
Codebase Verification
Inconsistent Import Paths for BlsPublicKey and BlsSignature
The import paths for BlsPublicKey and BlsSignature have not been consistently updated across the codebase. This could lead to inconsistencies and potential issues. Please update the following references to use the new import path from alloy::rpc::types::beacon:
bolt-sidecar/src/primitives/mod.rsbolt-sidecar/src/crypto/bls.rsbolt-sidecar/src/api/builder.rsbolt-sidecar/src/builder/signature.rs
Analysis chain
LGTM! Verify the impact of the import path change.
The import path for BlsPublicKey and BlsSignature has been updated to reflect the new module structure in the alloy library. Ensure that all references to BlsPublicKey and BlsSignature in the codebase are updated accordingly.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify all references to `BlsPublicKey` and `BlsSignature` in the codebase.
# Test: Search for the usage of `BlsPublicKey` and `BlsSignature`. Expect: Only occurrences of the new import path.
rg --type rust -A 5 $'BlsPublicKey'
rg --type rust -A 5 $'BlsSignature'
Length of output: 8963
| use alloy::{ | ||
| consensus::constants::ETH_TO_WEI, | ||
| primitives::{uint, Uint}, | ||
| }; | ||
| use dotenvy::dotenv; |
There was a problem hiding this comment.
Tip
Codebase Verification
Ensure comprehensive test coverage for RpcClient.
The removal of the test_get_proof test case might indicate a shift in testing strategy. Ensure that the remaining tests are comprehensive and cover all necessary scenarios, specifically including direct tests for RpcClient.
Analysis chain
Ensure comprehensive test coverage for RpcClient.
The removal of the test_get_proof test case might indicate a shift in testing strategy. Ensure that the remaining tests are comprehensive and cover all necessary scenarios.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the test coverage for `RpcClient`.
# Test: Search for test functions. Expect: Comprehensive test coverage for `RpcClient`.
rg --type rust -A 5 $'#[tokio::test]'
Length of output: 3578
Script:
#!/bin/bash
# Description: Verify the test coverage for `RpcClient`.
# Test: Search for all test functions. Expect: Comprehensive test coverage for `RpcClient`.
rg --type rust -A 5 '#\[test\]'
Length of output: 5552
Script:
#!/bin/bash
# Description: Verify the test coverage for `RpcClient`.
# Test: Search for `RpcClient` within the test files. Expect: Comprehensive test coverage for `RpcClient`.
rg 'RpcClient' $(rg --files-with-matches '#\[test\]')
Length of output: 725
Script:
#!/bin/bash
# Description: Verify the test coverage for `RpcClient` in `bolt-sidecar/src/builder/payload_builder.rs`.
# Test: Search for test functions within `bolt-sidecar/src/builder/payload_builder.rs`.
rg --type rust -A 5 '#\[test\]' bolt-sidecar/src/builder/payload_builder.rs
Length of output: 352
Script:
#!/bin/bash
# Description: Verify the test coverage for `RpcClient` in the entire codebase.
# Test: Search for test cases that directly test `RpcClient`.
rg 'RpcClient::new' $(rg --files-with-matches '#\[test\]')
Length of output: 559
bolt-sidecar:
call_trace_manager.rsandstate_root.rsSummary by CodeRabbit
New Features
ApiErrorenum with more precise error types.FallbackPayloadBuilderto manage request data.Bug Fixes
HeadEventandU256.Refactor
alloylibrary.Chores