-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bolt-cli
revamp: add Dirk support
#309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
changed the title
feat:
feat: Oct 24, 2024
bolt-cli
revampbolt-cli
revamp: add Dirk support
merklefruit
force-pushed
the
nico/feat/bolt-cli
branch
from
October 24, 2024 08:50
818eb40
to
bf13b0f
Compare
mempirate
reviewed
Oct 24, 2024
thedevbirb
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the renaming the code looks great! It's awesome there is also a test in the CI, great work.
mempirate
reviewed
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starts #307
Overview
This PR adds support for Dirk as remote signer for generating BLS key delegations.
We can now list, unlock remote accounts and sign arbitrary data through the eth2-signer-api.
This PR comes with an e2e test using Dirk as a background process with pre-fabricated certificates and wallets.
To run the test, use the following command:
cargo test --package bolt-cli --bin bolt-cli -- utils::dirk::tests::test_dirk_connection_e2e --exact --show-output --ignored
The guide can be found in the README here.
tasks: