Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: solve outstanding TODOs #361

Merged
merged 10 commits into from
Nov 8, 2024
Merged

feat: solve outstanding TODOs #361

merged 10 commits into from
Nov 8, 2024

Conversation

merklefruit
Copy link
Collaborator

@merklefruit merklefruit commented Nov 6, 2024 •
edited
Loading

starts #359

  • feat(sidecar): added a robust generic future retry system
  • feat(sidecar): removed usage of validator indexes, in favor of validator pubkeys
  • chore(sidecar): remove TODOs in primitives module (nits, docs, and reminders)

Note: accompanying kurtosis PR: chainbound/ethereum-package#24

@merklefruit merklefruit mentioned this pull request Nov 6, 2024
Closed
@merklefruit merklefruit self-assigned this Nov 6, 2024
@merklefruit merklefruit added the C: bolt-sidecar Component: bolt-sidecar label Nov 6, 2024
thedevbirb
thedevbirb approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor! Thank you

bolt-sidecar/src/common.rs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, and nice tests!

@thedevbirb
Copy link
Contributor

Can you fix CI?

@merklefruit
Copy link
Collaborator Author

Can you fix CI?

Since it's just linkspector failing on links that are unrelated to this PR (in bolt-contracts), I suggest fixing them on holesky-launch directly

@merklefruit merklefruit mentioned this pull request Nov 7, 2024
Merged
@thedevbirb thedevbirb merged commit 43f3b17 into lore/feat/holesky-launch Nov 8, 2024
2 of 3 checks passed
@thedevbirb thedevbirb deleted the nico/feat/solve-outstanding-todos branch November 8, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedevbirb thedevbirb thedevbirb approved these changes

Assignees

@merklefruit merklefruit

Labels
C: bolt-sidecar Component: bolt-sidecar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merklefruit @thedevbirb