chore(bolt-sidecar): get block gas limit from config #594
+58
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedevbirb
approved these changes
Dec 19, 2024
bolt-sidecar/src/config/chain.rs
Outdated
| @@ -20,6 +20,9 @@ pub const DEFAULT_COMMITMENT_DEADLINE_IN_MILLIS: u64 = 8_000; | |||
| /// Default slot time duration in seconds. | |||
| pub const DEFAULT_SLOT_TIME_IN_SECONDS: u64 = 12; | |||
|
|
|||
| /// Default gas limit for the sidecar. | |||
| pub const DEFAULT_GAS_LIMIT: u128 = 30_000_000; | |||
There was a problem hiding this comment.
Using u64 for gas limit is more than enough, even u16 can make it :D
estensen
commented
Dec 19, 2024
| @@ -20,6 +20,9 @@ pub const DEFAULT_COMMITMENT_DEADLINE_IN_MILLIS: u64 = 8_000; | |||
| /// Default slot time duration in seconds. | |||
| pub const DEFAULT_SLOT_TIME_IN_SECONDS: u64 = 12; | |||
|
|
|||
| /// Default gas limit for the sidecar. | |||
| pub const DEFAULT_GAS_LIMIT: u64 = 30_000_000; | |||
There was a problem hiding this comment.
technically it would fit in u32 but using u64 since it's that's what Alloy does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PooledTransactionsElementare rugged so need #571 first