Improve Dagger runner backend #1470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingyplus
force-pushed
the
dagger-improvement
branch
from
79e28f5
to
e32c89e
Compare
wingyplus
commented
Sep 2, 2024
| return ref.String(), nil | ||
| } | ||
|
|
||
| func (d *daggerLoader) RemoveImage(ctx context.Context, ref string) error { | ||
| return os.Remove(filepath.Join(d.tmpDir, imageTarName)) | ||
| return nil |
There was a problem hiding this comment.
Unlike Docker, the Dagger has no mechanism to remove the image. So I lave it to nil and let the runner delete all files when calling Close instead.
wingyplus
commented
Sep 2, 2024
| _, err := output.Export( | ||
| ctx, | ||
| cfg.WorkspaceDir+"/melange-out", | ||
| dagger.DirectoryExportOpts{Wipe: true}, |
There was a problem hiding this comment.
Uses wipe option to make sure packages directory is clean.
Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>
wingyplus
force-pushed
the
dagger-improvement
branch
from
e32c89e
to
1d64ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Melange Pull Request Template
Functional Changes
failed to build package: unable to run package hello pipeline: unable to run pipeline: input: container.import resolve: recover: no manifest for platform linux/amd64 and tagbecause the runner doesn't build on correct platform.TestUsabilityusesdagger.Client.Versionto test the client can connect to engine.