Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set output to required for cargo/build pipeline #1596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kranurag7
Copy link
Contributor

In some projects, we get a lot of outputs in ./target/release directory and if we don't set output then it tries to install a lot directories which is not possible via install executable.

  • below is an example listing in /target/release directory.
~ # ls target/release/
build        deps         examples     incremental  probe        probe.d      pub          pub.d
  • logs from melange pipeline
2024/10/23 21:14:59 WARN install: omitting directory 'target/release/build' uses=cargo/build
2024/10/23 21:14:59 WARN install: omitting directory 'target/release/deps' uses=cargo/build
2024/10/23 21:14:59 WARN install: omitting directory 'target/release/examples' uses=cargo/build
2024/10/23 21:14:59 WARN install: omitting directory 'target/release/incremental' uses=cargo/build

Fixes #1582

Note

We still need to think about how can we support installing more than one binaries from ./target/release directory but I'll open up another patch for that.

@ckoehler
Copy link

output could be a list of files or globs, to install multiple things, including libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo pipeline error
2 participants