Add 10000 bytes check when creating P2WSH script

chaintope · Jun 30, 2024 · 85c77ee · 85c77ee
1 parent a8f5e4c
commit 85c77ee
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/bitcoin/script/script.rb b/lib/bitcoin/script/script.rb
@@ -76,9 +76,11 @@ def self.to_multisig_script(m, pubkeys, sort: false)
     end
 
     # generate p2wsh script for +redeem_script+
-    # @param [Script] redeem_script target redeem script
-    # @param [Script] p2wsh script
+    # @param [Bitcoin::Script] redeem_script target redeem script
+    # @return [Bitcoin::Script] p2wsh script
+    # @raise [ArgumentError] If the script size exceeds 10,000 bytes
     def self.to_p2wsh(redeem_script)
+      raise ArgumentError, 'P2WSH witness script must be 10,000 bytes or less.' if redeem_script.size > Bitcoin::MAX_SCRIPT_SIZE
       new << WITNESS_VERSION_V0 << redeem_script.to_sha256
     end
 

diff --git a/spec/bitcoin/script/script_spec.rb b/spec/bitcoin/script/script_spec.rb
@@ -182,6 +182,16 @@
         expect(subject.to_addr).to eq('tb1q8nsuwycru4jyxrsv2ushyaee9yqyvvp2je60r4n6yjw06t88607sajrpy8')
       end
     end
+
+    context 'invalid script length' do
+      it 'should raise error' do
+        boundary = Bitcoin::Script.new
+        10_000.times { boundary << OP_0 }
+        expect{ Bitcoin::Script.to_p2wsh(boundary) }.not_to raise_error
+        boundary << OP_0
+        expect{ Bitcoin::Script.to_p2wsh(boundary) }.to raise_error(ArgumentError)
+      end
+    end
   end
 
   describe 'P2TR script' do