guest side proof fail

[eyusufatik]

Description

since risc0 guest side proof verification APIs only support proofs that are verifiable, we need to verify failing of proofs with host side verification API.

TODO:

• figure out how to test this in e2e

Linked Issues

Fixes #1643

[codecov]

Codecov Report

Attention: Patch coverage is 35.93750% with 41 lines in your changes missing coverage. Please review.

Project coverage is 78.4%. Comparing base (af3713c) to head (a98a1f9).

Files with missing lines	Patch %	Lines
crates/light-client-prover/src/da_block_handler.rs	0.0%	18 Missing ⚠️
crates/risc0/src/guest.rs	0.0%	8 Missing ⚠️
crates/risc0/src/host.rs	0.0%	7 Missing ⚠️
crates/sovereign-sdk/adapters/mock-zkvm/src/lib.rs	58.3%	5 Missing ⚠️
crates/light-client-prover/src/circuit.rs	84.2%	3 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
crates/light-client-prover/src/runner.rs	0.0% <ø> (ø)
...n-sdk/rollup-interface/src/state_machine/zk/mod.rs	83.3% <ø> (ø)
crates/light-client-prover/src/circuit.rs	90.8% <84.2%> (+4.8%)	⬆️
crates/sovereign-sdk/adapters/mock-zkvm/src/lib.rs	57.4% <58.3%> (+<0.1%)	⬆️
crates/risc0/src/host.rs	65.7% <0.0%> (-3.4%)	⬇️
crates/risc0/src/guest.rs	0.0% <0.0%> (ø)
crates/light-client-prover/src/da_block_handler.rs	0.0% <0.0%> (ø)

... and 2 files with indirect coverage changes

[jfldde]

Suggested change

	if current_proof_index
	!= expected_to_fail_hints.peek().copied().unwrap_or(u32::MAX)
	{
	// if index is not in the expected to fail hints, then it should pass
	G::verify(&journal, &batch_proof_method_id.into())
	.expect("Proof hinted to pass failed");
	} else {
	// if index is in the expected to fail hints, then it should fail
	G::verify_expected_to_fail(&proof, &batch_proof_method_id.into())
	.expect_err("Proof hinted to fail passed");
	expected_to_fail_hints.next();
	current_proof_index += 1;
	if expected_to_fail_hints.next_if(|&x| x == current_proof_index).is_none() {
	// if index is not in the expected to fail hints, then it should pass
	G::verify(&journal, &batch_proof_method_id.into())
	.expect("Proof hinted to pass failed");
	} else {
	// if index is in the expected to fail hints, then it should fail
	G::verify_expected_to_fail(&proof, &batch_proof_method_id.into())
	.expect_err("Proof hinted to fail passed");
	current_proof_index += 1;
	continue;
	}

Can use next_if so we don't need to unwrap to u32::MAX.

[jfldde]

LGTM but for the small nit above