Watchtower get params #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekrembal
requested changes
Dec 10, 2024
core/src/rpc/watchtower.rs
Outdated
|
|
||
| WinternitzPubkey { | ||
| d: operator_index as u32, | ||
| n0: timetx_index as u32, |
There was a problem hiding this comment.
These are incorrect, d and n0 should be the digit and message length, BUT we can get rid of these d and n0 in the proto file as well, since the receiver will know them
core/src/servers.rs
Outdated
|
|
||
| create_watchtower_grpc_server(BridgeConfig { | ||
| port: port + i as u16, | ||
| verifier_endpoints: Some( |
There was a problem hiding this comment.
Watchtower server does not need verifier endpoints and operator endpoints
core/src/watchtower.rs
Outdated
| config.network, | ||
| ); | ||
|
|
||
| let verifier_endpoints = |
There was a problem hiding this comment.
Watchtower server does not need verifier endpoints and operator endpoints
core/src/watchtower.rs
Outdated
| _db, | ||
| actor, | ||
| index: config.index, | ||
| num_operators: config.num_operators as u32, |
There was a problem hiding this comment.
These are written in config, we can store the config
core/tests/data/test_config.toml
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Host and port of the current actor (operator or verifier) | |||
| # Host, port and index of the current actor (operator or verifier) | |||
There was a problem hiding this comment.
(operator, verifier, or watchtower)
ekrembal
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements
watchtower::get_paramsRPC call.Linked Issues
Testing
Added unit tests.