Modernization and support for video, reachability changes, STUN, TURN and more! #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use PJ_LOG instead of NSLog when appropriate. Add support for video. Add support for handling reachability changes. Add support for STUN and TURN servers that can be changed on-demand. Add support for detecting system DNS servers (these are also updated on reachability changes). Add API to verify SIP URI strings. Do not assume sip and support sips addresses. For safety, make sure that stringWithPJString copies the memory. Add support for keeping alive a TCP connection in the background (pre iOS 9). Prioritize Opus and H264. Rename GSLogSipError to GSLogPJSIPError. Support custom headers in SIP INVITES. Add the ability to answer a call with codes. Add support for parsing SIP Reason headers (RFC 3326) on CANCEL messages. Fix wrong if (self = [super init]) initializers. Add support for checking if calls have ended. Add support for checking the remote information in a call. Add support for getting the last SIP status text and code in a call. Make all delegates weak.
|
@sammacros hey this month has been super busy so I barely checked up on my projects. Thanks for this!!! I'll try to check this out on the weekend, feel free to spam ping me if I disappear for whatever reason. |
|
@chakrit : Is this branch merge on master branch? I am looking for support for checkking if calls have ended. I tried using GSSIPCallStateDidChangeNotification notification observation, but not getting enough help to get each call state. I also tried using GSCallStatus in GSCall class but that also did not work somehow. JFYI, I am using this with swift language. Let me know if you have any input to check the call status, whether call is connected, disconnected. |
OnurVar
approved these changes
Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes are committed back to the public domain. Thanks for Gossip.
Note that PJSIP trunk is recommended, with a minimum of PJSIP 2.5.5 as it contains patches to support recent a modern OpenH264 and to fix some issues with video support in Darwin.
Note that I have not tested the sample project to see if it is compatible with all these new changes. I have a separate build system to support OpenSSL, OpenH264 and more.
Major
Minor