-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Discord Library Upgrade #162
base: main
Are you sure you want to change the base?
Conversation
It's not done, nor is it in a state where it works (although it doesn't crash anymore). Don't spend too much time looking through it, but if you could answer the questions I had above, that would be cool. Opening the PR to start collaboration on the update |
Thanks for starting this pull request! The class overrides are rather hacky, and I can't recall what each of them accomplishes given that it's been a few years since I wrote them. It just happened that everything was needed to have the bot working at that time. I would strongly suggest to experiment and see what works since that's what I did as well. Also, perhaps we could restrict the scope of this pull request to just the library upgrade, and leave out features like slash commands and buttons for now. Hopefully that can speed up the development cycle, which is important because this pull request would be the foundation for everything else. |
Okay we love hacky. I also wasn't sure on feasibility, but if the redis caching happened at the twilight stage, would that make this more maintainable? Since you have complete control over that - just a thought. Agree on the scope for this PR - I meant to add spacing between the tasks to show what I wanted to do now versus before a 4.0 release. That was the reason for merging this into a dev branch rather than main. |
chore: sync from main
0e5a511
to
529ada7
Compare
Summary
Upgrades the bot to use Discord.py 2.3.2
@chamburr Can you make this merge into a dev branch? I'd like to have this merged once the migration is stable, but hold off on merging into main until buttons and views are added.
Notes
Rough todo
After this PR, but before mainstream release.