fix: Handling datetime in client to_dict() #1314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgadling
requested changes
Nov 6, 2024
manasaV3
force-pushed
the
mvenkatakrishnan/client_fix
branch
from
59dc3c7
to
5a02e28
Compare
jgadling
reviewed
Nov 6, 2024
| def to_dict(self) -> Dict[str, Any]: | ||
| """Return a dictionary representation of this object's attributes""" | ||
| return {k: getattr(self, k) for k in self._get_scalar_fields()} | ||
|
|
||
| def to_json_dict(self) -> Dict[str, Any]: | ||
| """Return a JSON encoder friendly representation of this object's attributes""" | ||
| return {key: self._serialize(val) for key, val in self.to_dict().items()} |
There was a problem hiding this comment.
Python's json module already supplies a way to convert python values to json-compatible values (docs here and example implementation here ). Do we need to implement this functionality in our client, or can we leave it to users to work with python's standard library?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
to_dict()method raises serialization errors for objects that have a date time object. Ex: Dataset, Tomogram,..This fix serializes the date time into the iso_format string.