-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: instrument timing for slow requests #7217
Conversation
…nto tsmith/visium-functional-tewt
…nto tsmith/visium-functional-tewt # Conflicts: # tests/functional/backend/corpora/test_api.py
Deployment Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7217 +/- ##
==========================================
+ Coverage 92.84% 92.86% +0.01%
==========================================
Files 192 192
Lines 16340 16376 +36
==========================================
+ Hits 15171 15207 +36
Misses 1169 1169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ut' into tsmith/7190-get-collection-timeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should look into using datadog tracing for this long-term, but short-term this seems reasonable
I wonder if we can do this already with datadog |
It looks like it can. I'd rather not add the overhead in this case. |
Reason for Change
Changes
Testing steps